Code review comment for lp:~abentley/workspace-runner/known-hosts

Revision history for this message
Martin Packman (gz) wrote :

Looks fine.

The next step however, if we want to add more ssh configuration, should be just having a dedicated ssh config dir for the SSHConnection object, rather than giving everything as command line options. That gives use true isolation from the user's ssh config and we can be precise about what elements we want to preserve.

review: Approve

« Back to merge proposal