Merge lp:~abentley/lp-release-manager-tools/exclude-exact-finish into lp:~sinzui/lp-release-manager-tools/trunk

[Aaron Bentley]

Ignore bugs created or closed at the cycle's finish.

Bug events (being open or closed) should not be part of two cycles. The current collation includes the start and finish of the cycle. The finish of one cycle is the start of the following cycle (if there is one). So an event that happens at the finish of a cycle will usually be part of that cycle and the following cycle.

To fix this, we must exclude either the start or the finish of the cycle. To me, it is intuitive that the start of the cycle should be included, therefore we should exclude the end of the cycle. This branch does that.

[Curtis Hovey (sinzui)]

\o/ I have been meaning to do this.

review: Approve (code)

Unmerged revisions

31. By Aaron Bentley on 2014-06-19

Exclude dates at the 'finish' value.

=== modified file 'lp_release_tools/report_bugs.py'
--- lp_release_tools/report_bugs.py	2014-06-17 18:21:12 +0000
+++ lp_release_tools/report_bugs.py	2014-06-19 14:47:10 +0000
@@ -168,7 +168,7 @@
         for cycle in cycles:
             if bug.date_closed and bug.date_closed < cycle.start:
                 break
-            if bug.date_created > cycle.finish:
+            if bug.date_created >= cycle.finish:
                 continue
             if not bug.date_closed or not bug.date_closed < cycle.finish:
                 cycle.total.append(bug)
@@ -181,7 +181,7 @@
                 cycle.closed.append(bug)
             if (bug.date_created <= cycle.start
                     and (not bug.date_closed
-                         or bug.date_closed > cycle.finish)):
+                         or bug.date_closed >= cycle.finish)):
                 cycle.held.append(bug)