Merge lp:~abentley/launchpad/workitems-for-private-blueprints into lp:launchpad
Status: | Merged |
---|---|
Approved by: | Aaron Bentley |
Approved revision: | no longer in the source branch. |
Merged at revision: | 16154 |
Proposed branch: | lp:~abentley/launchpad/workitems-for-private-blueprints |
Merge into: | lp:launchpad |
Diff against target: |
219 lines (+66/-12) 6 files modified
lib/lp/blueprints/browser/person_upcomingwork.py (+2/-1) lib/lp/blueprints/browser/tests/test_person_upcomingwork.py (+24/-0) lib/lp/registry/interfaces/person.py (+5/-1) lib/lp/registry/model/person.py (+4/-2) lib/lp/registry/tests/test_person.py (+27/-7) lib/lp/testing/factory.py (+4/-1) |
To merge this branch: | bzr merge lp:~abentley/launchpad/workitems-for-private-blueprints |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Benji York (community) | code | Approve | |
Review via email: mp+129736@code.launchpad.net |
Commit message
Filter non-Public blueprints for +upcomingwork.
Description of the change
= Summary =
Fix bug #1056891: Specification privacy: upcoming work won't load for anyone if there's any private data on it
== Proposed fix ==
Use standard filter to ensure that only specifications visible to the viewer are listed.
== Pre-implementation notes ==
None
== LOC Rationale ==
Part of private products
== Implementation details ==
Add user parameter to getAssignedSpec
Update LaunchpadObject
== Tests ==
bin/test -t test_non_
== Demo and Q/A ==
1. create a project with other/proprietary license as a regular user
2. create a milestone targetted to a date in the future (in the next 180 days for it to show up on +upcomingwork page)
3. create a private blueprint, assign it to yourself and milestone from 2
4. add a workitem to the blueprint
5. check /people/
6. log in as a different user and load that same page
It should omit the proprietary spec's workitem, but otherwise work normally.
= Launchpad lint =
Checking for conflicts and issues in changed files.
Linting changed files:
lib/lp/
lib/lp/
lib/lp/
lib/lp/
lib/lp/
Looks good.