Merge lp:~abentley/launchpad/spec-creation-info-type into lp:launchpad
Status: | Merged |
---|---|
Approved by: | Aaron Bentley |
Approved revision: | no longer in the source branch. |
Merged at revision: | 15949 |
Proposed branch: | lp:~abentley/launchpad/spec-creation-info-type |
Merge into: | lp:launchpad |
Diff against target: |
512 lines (+204/-37) 9 files modified
lib/lp/blueprints/browser/specification.py (+64/-19) lib/lp/blueprints/browser/tests/test_specification.py (+117/-4) lib/lp/blueprints/interfaces/specification.py (+1/-4) lib/lp/blueprints/interfaces/specificationtarget.py (+3/-0) lib/lp/blueprints/model/specification.py (+2/-2) lib/lp/registry/model/distribution.py (+4/-0) lib/lp/registry/model/distroseries.py (+4/-4) lib/lp/registry/model/product.py (+5/-0) lib/lp/registry/model/productseries.py (+4/-4) |
To merge this branch: | bzr merge lp:~abentley/launchpad/spec-creation-info-type |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Deryck Hodge (community) | Approve | ||
Review via email:
|
Commit message
Allow specifying information_type when creating Blueprint.
Description of the change
= Summary =
Allow selecting information type when creating Specification
== Proposed fix ==
When creating a specification for an unknown target, allow any value. (Validation will catch places where an inappropriate value is used.)
When creating a specification for a known target, use the getAlloweedSpec
If only one value is allowed, do not show the choice.
== Pre-implementation notes ==
Discussed hiding when no choice is available with rick_h
== LOC Rationale ==
Part of Private Projects
== Implementation details ==
No changes are visible until blueprints.
DistroSeries and ProductSeries now explicitly delegate ISpecificationT
distro and product, to simplify implementation.
Distribution always returns PUBLIC as the sole allowed InformationType.
Product always returns the PUBLIC_PROPRIETARY set as the allowed InformationTypes, but this is a stub until Product policies for information types have landed.
As a driveby, removed ProductEditView
== Tests ==
bin/test specification
== Demo and Q/A ==
Create a specification
- From the root page
- From a sprint (meeting) page
- From a product page
- From a productseries page
- From a distribution page
- From a distroseries pagea
You should not be prompted for an information_type.
Enable blueprints.
Create a specification
- From the root page
- From a sprint (meeting) page
- From a product page
- From a productseries page
You should be prompted for an information type. The values provided should be "Public", "Proprietary", "Embargoed".
Create a specification
- From a distribution page
- From a distroseries pagea
You should not be prompted for an information_type.
= Launchpad lint =
Checking for conflicts and issues in changed files.
Linting changed files:
lib/lp/
lib/lp/
lib/lp/
lib/lp/
lib/lp/
lib/lp/
lib/lp/
lib/lp/
lib/lp/
Looks great. Good test coverage. Thanks!