Merge lp:~abentley/launchpad/sharing-language-bugs into lp:launchpad
Status: | Merged |
---|---|
Merged at revision: | 12852 |
Proposed branch: | lp:~abentley/launchpad/sharing-language-bugs |
Merge into: | lp:launchpad |
Diff against target: |
91 lines (+22/-5) 4 files modified
lib/lp/translations/browser/sourcepackage.py (+1/-1) lib/lp/translations/browser/tests/test_sharing_details.py (+5/-0) lib/lp/translations/javascript/sourcepackage_sharing_details.js (+3/-3) lib/lp/translations/javascript/tests/test_sourcepackage_sharing_details.js (+13/-1) |
To merge this branch: | bzr merge lp:~abentley/launchpad/sharing-language-bugs |
Related bugs: |
|
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
j.c.sackett (community) | Approve | ||
Review via email: mp+57715@code.launchpad.net |
Commit message
Fix various text issues on +sharing-details.
Description of the change
= Summary =
Fix bugs:
#758845: AJAX overlay says "Select productseries" in the translation sharing details Remove
#758852: Unhelpful title for "enable translations on an upstream project" dialog Remove
#758857: Linked branch in translations sharing details page shows branch URL without lp:// prefix Remove
== Proposed fix ==
Change AJAX overlay to "Select project series". Change title of "usage" dialog to "Configure translations", the same as the title of the page it comes from. Add lp: prefix to branch names.
== Pre-implementation notes ==
Discussed 758857 with jml
== Implementation details ==
None
== Tests ==
bin/test -t test_branch_
firefox lib/lp/
== Demo and Q/A ==
Go to the +sharing-details and verify the text is as expected.
= Launchpad lint =
Checking for conflicts and issues in changed files.
Linting changed files:
lib/lp/
lib/lp/
lib/lp/
lib/lp/
This is quite straightforward, and looks good to land.