Merge lp:~abentley/launchpad/retain-spr-builds into lp:launchpad/db-devel
Status: | Merged |
---|---|
Approved by: | Aaron Bentley |
Approved revision: | no longer in the source branch. |
Merged at revision: | 9979 |
Proposed branch: | lp:~abentley/launchpad/retain-spr-builds |
Merge into: | lp:launchpad/db-devel |
Diff against target: |
136 lines (+41/-15) 6 files modified
database/schema/patch-2208-28-0.sql (+7/-0) lib/canonical/launchpad/security.py (+2/-1) lib/lp/code/interfaces/sourcepackagerecipebuild.py (+1/-2) lib/lp/code/model/sourcepackagerecipe.py (+3/-8) lib/lp/code/model/sourcepackagerecipebuild.py (+1/-1) lib/lp/code/model/tests/test_sourcepackagerecipe.py (+27/-3) |
To merge this branch: | bzr merge lp:~abentley/launchpad/retain-spr-builds |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Stuart Bishop (community) | db | Approve | |
Tim Penhey (community) | Approve | ||
Robert Collins | db | Pending | |
Review via email: mp+40669@code.launchpad.net |
Commit message
NULL recipes in recipe builds on deletion.
Description of the change
= Summary =
Fix bug #645620: Deleting recipe leaves SourcePackageRe
traceability
== Proposed fix ==
Relax the not-null constraint for recipe on sourcepackagere
sourcepackagere
== Pre-implementation notes ==
Discussed with thumper
== Implementation details ==
None
== Tests ==
bin/test -t test_destroySel
== Demo and Q/A ==
Cannot be demoed because sourcepackagere
their recipe is deleted.
= Launchpad lint =
Checking for conflicts and issues in changed files.
Linting changed files:
lib/lp/
lib/canonical
database/
lib/lp/
lib/lp/
lib/lp/
./lib/canonical
721: E302 expected 2 blank lines, found 1
1256: E302 expected 2 blank lines, found 1
1466: E302 expected 2 blank lines, found 1
Looks good. Just one small point: when clearing out the recipe value from the builds, we should use a set based update rather than iterating over each one.