Merge lp:~abentley/launchpad/reject-private-recipe into lp:launchpad
Status: | Merged | ||||
---|---|---|---|---|---|
Approved by: | Robert Collins | ||||
Approved revision: | no longer in the source branch. | ||||
Merged at revision: | 11265 | ||||
Proposed branch: | lp:~abentley/launchpad/reject-private-recipe | ||||
Merge into: | lp:launchpad | ||||
Diff against target: |
356 lines (+148/-25) 7 files modified
lib/lp/code/browser/sourcepackagerecipe.py (+12/-5) lib/lp/code/browser/tests/test_sourcepackagerecipe.py (+29/-1) lib/lp/code/errors.py (+11/-0) lib/lp/code/model/sourcepackagerecipedata.py (+9/-4) lib/lp/code/model/tests/test_sourcepackagerecipe.py (+82/-13) lib/lp/code/model/tests/test_sourcepackagerecipebuild.py (+2/-1) lib/lp/testing/factory.py (+3/-1) |
||||
To merge this branch: | bzr merge lp:~abentley/launchpad/reject-private-recipe | ||||
Related bugs: |
|
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Robert Collins (community) | Approve | ||
Review via email:
|
Description of the change
= Summary =
Fix bug #607908: recipes with private branches should fail earlier
== Proposed fix ==
Raise an exception when creating or updating SourcePackageRe
private branches. Forward the exception to the user as a user error.
== Pre-implementation notes ==
None
== Implementation details ==
I fixed some lint, e.g. whitespace between 'And' and '('.
== Tests ==
bin/test -t test_creation -t setRecipeText -t test_edit_
== Demo and Q/A ==
= Launchpad lint =
Checking for conflicts and issues in changed files.
Linting changed files:
lib/lp/
lib/lp/
lib/lp/
lib/lp/
lib/lp/
lib/lp/
./lib/lp/
154: E202 whitespace before ')'
./lib/lp/
255: E231 missing whitespace after ','
279: E231 missing whitespace after ','
287: E231 missing whitespace after ','
294: E231 missing whitespace after ','
302: E231 missing whitespace after ','
328: E231 missing whitespace after ','
388: E231 missing whitespace after ','
685: Line exceeds 78 characters.
./lib/lp/
160: 'logout' imported but unused
846: E231 missing whitespace after ','
2752: E231 missing whitespace after ','
2754: E302 expected 2 blank lines, found 1
2781: E301 expected 1 blank line, found 0
1052: Line exceeds 78 characters.
2755: Line exceeds 78 characters.
./lib/lp/
133: E231 missing whitespace after ','
242: E202 whitespace before ']'
354: E231 missing whitespace after ','
386: E303 too many blank lines (3)
./lib/lp/
244: E231 missing whitespace after ','
+ Suggested use: provide as kwargs to ISourcePackageR ecipeSource. new
+ :param branches: The list of branches to use in the recipe. (If
+ unspecified, a branch will be autogenerated.
+ """
You are missing an end ) there.