Merge lp:~abentley/launchpad/qa-ready into lp:launchpad

[Aaron Bentley]

[Aaron Bentley (abentley)]

= Summary =
Implement a script that shows when a branch is ready to be QA-ed.

== Proposed fix ==
This branch provides a new script, qa-ready that shows whether a branch has
been deployed on edge and staging.

== Pre-implementation notes ==
Briefly discussed with Thumper

== Implementation details ==
The revno-determining strategies are stolen from the existing on-edge script.
Because the Launchpad repository has ghosts revisions, bzrlib will look for
them in remote branches. So I've provided a configuration option
"local_location" that lets you specify the local location of your stable and
db-stable branches.

== Tests ==
None

== Demo and Q/A ==
None

= Launchpad lint =

Checking for conflicts. and issues in doctests and templates.
Running jslint, xmllint, pyflakes, and pylint.
Using normal rules.

Linting changed files:
  utilities/qa-ready

[Paul Hummer (rockstar)]

<rockstar> abentley, I thought there was a page that had only the revno on it. Did that not pan out?
<abentley> rockstar, I don't think there's any such page.
<rockstar> abentley, okay.
<rockstar> abentley, the use of a bzr transport to screen scrape confuses me. What does it provide that a regular urllib or something doesn't?
<rockstar> Also, it sure would be nice if we had a successful-updates.txt for edge.
<rockstar> (not your problem though)
<abentley> rockstar, it respects all the configuration data that bzr does, so if you have proxies or things set up for bzr, those will apply to the transport also.
<rockstar> abentley, ah, okay.
<abentley> rockstar, also, it's familiar, and I don't see any reason *not* to use it.
<rockstar> abentley, that's the reason I would have suspected, but the former is also a very good reason.
<rockstar> s/suspected/expected/
<rockstar> abentley, was there a technical reason is_present appears after main?
<abentley> rockstar, no.
<rockstar> abentley, so, it's not a big deal, but I usually expect functions to be defined before I see the calls. It's still valid python, but hard to follow. Would you mind just bumping is_present above main?
<abentley> rockstar, sure.
<rockstar> abentley, r=rockstar

review: Approve (code)

=== added file 'utilities/qa-ready'
--- utilities/qa-ready	1970-01-01 00:00:00 +0000
+++ utilities/qa-ready	2010-02-25 19:13:18 +0000
@@ -0,0 +1,89 @@
+#!/usr/bin/python2.5
+#
+# Copyright 2010 Canonical Ltd.  This software is licensed under the
+# GNU Affero General Public License version 3 (see the file LICENSE).
+
+import re
+import sys
+
+from bzrlib.branch import Branch
+from bzrlib.config import LocationConfig
+from bzrlib.transport import get_transport
+
+
+class UsageError(Exception):
+    """Raised when the user makes a dumb error."""
+
+
+def get_staging_revision():
+    """Get the revision of db-stable deployed on staging.
+
+    :return: The staging revno as an int. Corresponds to a revision of
+        lp:launchpad/db-stable.
+    """
+    t = get_transport('https://staging.launchpad.net/')
+    last_line = t.get_bytes('successful-updates.txt').splitlines()[-1]
+    return int(last_line.split()[-1])
+
+
+def get_edge_revision():
+    """Get the revision of stable deployed on edge.
+
+    :return: The edge revno as an int. Corresponds to a revision of
+        lp:launchpad/stable.
+    """
+    t = get_transport('https://edge.launchpad.net/')
+    html = t.get_bytes('index.html')
+    revision_re = re.compile(r'\(r(\d+)\)')
+    for line in html.splitlines():
+        matches = revision_re.search(line)
+        if matches:
+            return int(matches.group(1))
+    raise ValueError("Could not find revision number on edge home page")
+
+
+def is_present(local_branch, deployed_location, deployed_revno):
+    local_mirror = LocationConfig(deployed_location).get_user_option(
+        'local_location')
+    if local_mirror is None:
+        print (
+            'Please configure a local_location for %s in locations.conf '
+            'to improve performance.' % deployed_location)
+        deployed_branch = Branch.open(deployed_location)
+    else:
+        deployed_branch = Branch.open(local_mirror)
+    deployed_branch.lock_read()
+    try:
+        deployed_rev_id = deployed_branch.get_rev_id(deployed_revno)
+        graph = local_branch.repository.get_graph(deployed_branch.repository)
+        return graph.is_ancestor(local_branch.last_revision(), deployed_rev_id)
+    finally:
+        deployed_branch.unlock()
+
+
+
+stable = 'bzr+ssh://bazaar.launchpad.net/~launchpad-pqm/launchpad/stable'
+dbstable = 'bzr+ssh://bazaar.launchpad.net/~launchpad-pqm/launchpad/db-stable'
+def main(argv):
+    if len(sys.argv) > 1:
+        location = sys.argv[1]
+    else:
+        location = '.'
+    b = Branch.open_containing(location)[0]
+    b.lock_read()
+    try:
+        print 'Branch: %s' % b.base
+        print 'Deployed on edge: %s' % is_present(
+            b, stable, get_edge_revision())
+        print 'Deployed on staging: %s' % is_present(
+            b, dbstable, get_staging_revision())
+    finally:
+        b.unlock()
+
+
+if __name__ == '__main__':
+    try:
+        sys.exit(main(sys.argv[1:]))
+    except UsageError, e:
+        print 'ERROR: %s' % e
+        sys.exit(1)