Merge lp:~abentley/launchpad/poppy-isolation into lp:launchpad/db-devel

[Aaron Bentley]

Disable poppy tests lacking proper isolation

= Summary =
Fix bug #588420: poppy sftp tests lack proper test isolation

== Proposed fix ==
Disable the tests until a proper fix can be done

== Pre-implementation notes ==
None

== Implementation details ==
These tests are multiplied over two scenarios: sftp and ftp. This change
removes the sftp scenarios so that the ftp versions continue to run.

== Tests ==
bin/test -t poppy

== Demo and Q/A ==
None

= Launchpad lint =

Checking for conflicts. and issues in doctests and templates.
Running jslint, xmllint, pyflakes, and pylint.
Using normal rules.

Linting changed files:
  lib/lp/poppy/tests/test_poppy.py

== Pyflakes notices ==

lib/lp/poppy/tests/test_poppy.py
    25: 'ZopelessAppServerLayer' imported but unused

    ^^^ This is used in commented-out code.

== Pylint notices ==

lib/lp/poppy/tests/test_poppy.py
    25: [W0611] Unused import ZopelessAppServerLayer

[Brad Crittenden (bac)]

Aaron,

Please move the comment above the commented-out code, format it as a proper XXX and add a period at the end.

Other than that it looks fine.

review: Approve (code)

[lp:~abentley/launchpad/poppy-isolation]

9421. By Aaron Bentley on 2010-06-01

Adjust comment formatting.

Unmerged revisions

9421. By Aaron Bentley on 2010-06-01

Adjust comment formatting.

9420. By Aaron Bentley on 2010-06-01

Disable tests lacking proper isolation

=== modified file 'lib/lp/poppy/tests/test_poppy.py'
--- lib/lp/poppy/tests/test_poppy.py	2010-05-28 13:42:13 +0000
+++ lib/lp/poppy/tests/test_poppy.py	2010-06-01 19:16:26 +0000
@@ -351,8 +351,10 @@
                  # XXX: In an ideal world, this would be in the UnitTests
                  # layer. Let's get one step closer to that ideal world.
                  'layer': ZopelessDatabaseLayer}),
-        ('sftp', {'server_factory': SFTPServer,
-                  'layer': ZopelessAppServerLayer}),
+# XXX: AaronBentley 2010-06-01 bug=588420: poppy sftp tests lack proper test
+# isolation.
+#        ('sftp', {'server_factory': SFTPServer,
+#                  'layer': ZopelessAppServerLayer}),
         ]
     suite = unittest.TestSuite()
     multiply_tests(tests, scenarios, suite)