Code review comment for lp:~abentley/launchpad/no-write-cwd

Revision history for this message
Julian Edwards (julian-edwards) wrote :

Looks good! Just a couple of small things:

1. change the indentation at line 41 of the diff as we discussed.
2. from lp.archiveuploader.tests import datadir
  then remove the hardcoded /lib/lp/archiveuploaders/tests/data

Thanks for making the change.

review: Approve

« Back to merge proposal