Merge lp:~abentley/launchpad/no-builds-recipe into lp:launchpad

[Aaron Bentley]

Show a message when a recipe has no builds

= Summary =
Provide a message under the builds table for a sourcepackage recipe when
there are no builds.

== Proposed fix ==
See above

== Pre-implementation notes ==
Discussed with rockstar

== Implementation details ==
Extracted the assertions in several browser tests into assertContainsRe.

Fixed some lint as a drive-by.

== Tests ==
bin/test -vvt test_index_no_builds test_sourcepackagerecipe

== Demo and Q/A ==
None

= Launchpad lint =

Checking for conflicts. and issues in doctests and templates.
Running jslint, xmllint, pyflakes, and pylint.
Using normal rules.

Linting changed files:
  lib/lp/code/templates/sourcepackagerecipe-index.pt
  lib/lp/code/browser/tests/test_sourcepackagerecipe.py

[Michael Hudson-Doyle (mwhudson)]

Looks fine. Did you consider adding assertContainsRe to TestCaseWithFactory?

review: Approve

=== modified file 'lib/lp/code/browser/tests/test_sourcepackagerecipe.py'
--- lib/lp/code/browser/tests/test_sourcepackagerecipe.py	2010-04-13 14:27:38 +0000
+++ lib/lp/code/browser/tests/test_sourcepackagerecipe.py	2010-04-20 06:04:18 +0000
@@ -1,6 +1,6 @@
 # Copyright 2010 Canonical Ltd.  This software is licensed under the
 # GNU Affero General Public License version 3 (see the file LICENSE).
-# pylint: disable-msg=F0401
+# pylint: disable-msg=F0401,E1002
 
 """Tests for the product view classes and templates."""
 
@@ -63,7 +63,7 @@
             recipe=recipe, distroseries=self.squirrel, archive=self.ppa))
         build.buildstate = BuildStatus.FULLYBUILT
         build.datebuilt = datetime(2010, 03, 16, tzinfo=utc)
-        pattern = re.compile(dedent("""\
+        self.assertContainsRe(dedent("""\
             Master Chef
             Branches
             Description
@@ -89,15 +89,29 @@
             Request build\(s\)
             Recipe contents
             # bzr-builder format 0.2 deb-version 1.0
-            lp://dev/~chef/chocolate/cake"""), re.S)
-        main_text = self.getMainText(recipe)
-        self.assertTrue(pattern.search(main_text), repr(main_text))
+            lp://dev/~chef/chocolate/cake"""), self.getMainText(recipe))
+
+    def assertContainsRe(self, regex, text):
+        """Assert that the text contains the specified regex."""
+        pattern = re.compile(regex, re.S)
+        self.assertTrue(pattern.search(text), text)
+
+    def test_index_no_builds(self):
+        """A message should be shown when there are no builds."""
+        recipe = self.makeRecipe()
+        self.assertContainsRe(dedent("""\
+            Build records
+            Status
+            Time
+            Distribution series
+            Archive
+            This recipe has not been built yet."""), self.getMainText(recipe))
 
     def test_index_no_suitable_builders(self):
         recipe = self.makeRecipe()
         removeSecurityProxy(self.factory.makeSourcePackageRecipeBuild(
             recipe=recipe, distroseries=self.squirrel, archive=self.ppa))
-        pattern = re.compile(dedent("""\
+        self.assertContainsRe(dedent("""\
             Build records
             Status
             Time
@@ -106,9 +120,7 @@
             No suitable builders
             Secret Squirrel
             Secret PPA
-            Request build\(s\)"""), re.S)
-        main_text = self.getMainText(recipe)
-        self.assertTrue(pattern.search(main_text), main_text)
+            Request build\(s\)"""), self.getMainText(recipe))
 
     def makeBuildJob(self, recipe):
         """Return a build associated with a buildjob."""
@@ -122,7 +134,7 @@
         recipe = self.makeRecipe()
         self.makeBuildJob(recipe)
         self.factory.makeBuilder()
-        pattern = re.compile(dedent("""\
+        self.assertContainsRe(dedent("""\
             Build records
             Status
             Time
@@ -134,9 +146,7 @@
             Secret Squirrel
             Secret PPA
             Request build\(s\)
-            Recipe contents"""), re.S)
-        main_text = self.getMainText(recipe)
-        self.assertTrue(pattern.search(main_text), main_text)
+            Recipe contents"""), self.getMainText(recipe))
 
     def test_builds(self):
         """Ensure SourcePackageRecipeView.builds is as described."""

=== modified file 'lib/lp/code/templates/sourcepackagerecipe-index.pt'
--- lib/lp/code/templates/sourcepackagerecipe-index.pt	2010-04-09 15:38:22 +0000
+++ lib/lp/code/templates/sourcepackagerecipe-index.pt	2010-04-20 06:04:18 +0000
@@ -90,6 +90,9 @@
             </tr>
           </tbody>
         </table>
+        <p tal:condition="not: view/builds">
+          This recipe has not been built yet.
+        </p>
         <tal:request replace="structure context/menu:context/request_builds/fmt:link" />
       </div>
       <div class='portlet'>