Merge lp:~abentley/launchpad/new-score into lp:launchpad
Status: | Merged | ||||
---|---|---|---|---|---|
Approved by: | Edwin Grubbs | ||||
Approved revision: | no longer in the source branch. | ||||
Merged at revision: | 11254 | ||||
Proposed branch: | lp:~abentley/launchpad/new-score | ||||
Merge into: | lp:launchpad | ||||
Diff against target: |
107 lines (+25/-9) 5 files modified
lib/lp/code/browser/tests/test_sourcepackagerecipe.py (+2/-2) lib/lp/code/model/sourcepackagerecipe.py (+2/-1) lib/lp/code/model/sourcepackagerecipebuild.py (+1/-1) lib/lp/code/model/tests/test_sourcepackagerecipe.py (+16/-4) lib/lp/code/templates/sourcepackagerecipebuild-index.pt (+4/-1) |
||||
To merge this branch: | bzr merge lp:~abentley/launchpad/new-score | ||||
Related bugs: |
|
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Edwin Grubbs (community) | code | Approve | |
Review via email: mp+31178@code.launchpad.net |
Commit message
Revise build scores and show in UI
Description of the change
= Summary =
Fix bug #610960: recipe build scores should be higher
== Proposed fix ==
Score manual builds at 2505, like a similar binary build would be scored.
Score automatic builds at 2405, so manual builds take precedence.
== Pre-implementation notes ==
Discussed with bigjools.
== Implementation details ==
Honour the relative_
Show the build score on the build page (like binary builds.)
== Tests ==
bin/test -t render_index -t requestBuild test_sourcepack
== Demo and Q/A ==
Create a build. Its score should be shown as 2505.
= Launchpad lint =
Checking for conflicts and issues in changed files.
Linting changed files:
lib/lp/
lib/lp/
lib/lp/
lib/lp/
lib/lp/
./lib/lp/
216: E231 missing whitespace after ','
240: E231 missing whitespace after ','
248: E231 missing whitespace after ','
255: E231 missing whitespace after ','
263: E231 missing whitespace after ','
301: E231 missing whitespace after ','
361: E231 missing whitespace after ','
658: Line exceeds 78 characters.
./lib/lp/
46: E231 missing whitespace after ','
./lib/lp/
184: E301 expected 1 blank line, found 0
./lib/lp/
243: E231 missing whitespace after ','
Hi Aaron,
This branch looks good.
-Edwin