Merge lp:~abentley/launchpad/new-bug-fields into lp:launchpad

Proposed by Aaron Bentley
Status: Merged
Merged at revision: 14267
Proposed branch: lp:~abentley/launchpad/new-bug-fields
Merge into: lp:launchpad
Diff against target: 0 lines
To merge this branch: bzr merge lp:~abentley/launchpad/new-bug-fields
Reviewer Review Type Date Requested Status
Brad Crittenden (community) code Approve
Review via email: mp+81310@code.launchpad.net

Commit message

New fields for bug listings.

Description of the change

= Summary =
Provide new fields for dynamic bug listings: last_updated, assignee, reporter, age, tags.

== Proposed fix ==
See above

== Pre-implementation notes ==
Discussed with deryck

== Implementation details ==
Wrote DateTimeFormatterAPI.durationsince() to match the text given in the mockups. There doesn't seem to be an existing implementation.

Leap years make deriving a year count from a number of days tricky, so _yearDelta simply subtracts one year from another, and then adjusts for the possibility that the difference between the years may be greater than the difference between the two values.

== Tests ==
bin/test -t hiding -t test_model bugtask

== Demo and Q/A ==
The dynamic bug listings should work normally and look the same, but the model should contain the new fields.

= Launchpad lint =

Checking for conflicts and issues in changed files.

Linting changed files:
  lib/lp/app/tests/test_tales.py
  lib/lp/bugs/browser/tests/test_bugtask.py
  lib/lp/bugs/browser/bugtask.py
  lib/lp/bugs/templates/buglisting.mustache
  lib/lp/app/browser/tales.py

To post a comment you must log in.
Revision history for this message
Brad Crittenden (bac) wrote :

Hi Aaron,

I'd move the test number == 0 to above line 34 to be clearer, especially since number gets redefined previously in the hours section. The make the 'if' an 'elif' for the test for minutes.

Other than that this looks like a very nice branch. Thanks.

review: Approve (code)

Preview Diff

Empty