Merge lp:~abentley/launchpad/mandatory-bug-title into lp:launchpad

[Aaron Bentley]

Make bug title a mandatory field.

= Summary =
Make bug titles mandatory. There is no value in hiding them. This happens to fix bug #894449: It's possible to create an entirely useless bug listing

== Proposed fix ==

== Pre-implementation notes ==
Discussed with the product team

== Implementation details ==
As well as making title mandatory, this also changes cookie handling.

While cookies control field visibility, they can no longer add fields not present in the defaults, so they can't add the obsolete show_title field. Similarly, fields that are missing from the cookie are now provided from the default.

== Tests ==
bin/test browser.tests.test_bugtask

== Demo and Q/A ==
Go to a dynamic bug listing page. Click the gear. "Bug title" should not be listed, but the titles should be displayed in the listings.

= Launchpad lint =

Checking for conflicts and issues in changed files.

Linting changed files:
  lib/lp/app/browser/stringformatter.py
  lib/lp/registry/templates/product-index.pt
  lib/lp/app/browser/tests/test_stringformatter.py
  lib/lp/bugs/javascript/buglisting.js
  versions.cfg
  setup.py
  lib/lp/bugs/templates/buglisting-default.pt
  lib/lp/services/features/flags.py
  lib/lp/bugs/browser/tests/test_bugtask.py
  lib/lp/bugs/browser/bugtask.py
  lib/lp/bugs/javascript/tests/test_buglisting_utils.html
  lib/lp/bugs/templates/buglisting.mustache
  lib/lp/bugs/javascript/tests/test_buglisting_utils.js
  lib/lp/registry/browser/person.py
  lib/lp/bugs/javascript/tests/test_buglisting.js
  lib/lp/bugs/javascript/buglisting_utils.js

./lib/lp/registry/templates/product-index.pt
      58: Line has trailing whitespace.
./lib/lp/app/browser/tests/test_stringformatter.py
     439: Line exceeds 78 characters.
     439: E501 line too long (82 characters)

[Brad Crittenden (bac)]

Looks good Aaron. Would you mind terribly making this comment a sentence, i.e. capitalization and punctuation?

# skip unsupported fields (from old cookies)

I may be showing my ignorance of how cookies are constructed but are we assured 'true' and 'false' are always spelled that way and never 'True' or 'FALSE'?

review: Approve (code)

[Aaron Bentley (abentley)]

The cookies are set from very tightly-related code, BugListingConfigUtil.setCookie, so there's no chance of 'True' or 'FALSE'. I'm happy to change the comment to a sentence.