Merge lp:~abentley/launchpad/longer-mq-timeout into lp:launchpad

Proposed by Aaron Bentley on 2012-07-30
Status: Merged
Approved by: Aaron Bentley on 2012-07-30
Approved revision: no longer in the source branch.
Merged at revision: 15717
Proposed branch: lp:~abentley/launchpad/longer-mq-timeout
Merge into: lp:launchpad
Diff against target: 12 lines (+1/-1)
1 file modified
lib/lp/services/job/tests/test_celeryjob.py (+1/-1)
To merge this branch: bzr merge lp:~abentley/launchpad/longer-mq-timeout
Reviewer Review Type Date Requested Status
Benji York (community) code 2012-07-30 Approve on 2012-07-30
Review via email: mp+117324@code.launchpad.net

Commit Message

Fix intermittant test failure.

Description of the Change

= Summary =
Fix bug #1031018: TestRunMissingJobs.test_find_missing_ready fails intermittantly

== Proposed fix ==
Increase the maximum waiting time to 1 minute.

== Pre-implementation notes ==
None

== LOC Rationale ==
LOC neutral

== Implementation details ==
find_missing_ready waits for the message queue to be populated, and this has reduced, but not eliminated test failures. I hope that increasing the time limit will eliminate them.

== Tests ==
bin/test -t TestRunMissingJobs.test_find_missing_ready

== Demo and Q/A ==
None

= Launchpad lint =

Checking for conflicts and issues in changed files.

Linting changed files:
  lib/lp/services/job/tests/test_celeryjob.py

To post a comment you must log in.
Benji York (benji) wrote :

This is understandable.

review: Approve (code)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'lib/lp/services/job/tests/test_celeryjob.py'
2--- lib/lp/services/job/tests/test_celeryjob.py 2012-07-26 19:26:17 +0000
3+++ lib/lp/services/job/tests/test_celeryjob.py 2012-07-30 19:12:21 +0000
4@@ -45,7 +45,7 @@
5 delivery.
6 """
7 from lazr.jobrunner.celerytask import list_queued
8- for x in range(100):
9+ for x in range(600):
10 actual_len = len(list_queued(app, queues))
11 if actual_len == expected_len:
12 return