Merge lp:~abentley/launchpad/info-type-app-config into lp:launchpad

[Aaron Bentley]

Information type configures applications.

= Summary =
Information type configures applications.

== Proposed fix ==
Answers and private projects are mutually exclusive. The Product information_type, not the license, determines the sharing policies. Embargoed sets policies to EMBARGOED_OR_PROPRIETARY where applicable.

== Pre-implementation notes ==
Discussed with deryck

== LOC Rationale ==
Part of private projects.

== Implementation details ==
Updated createProduct to use information_type to determine default sharing policies. Added Specification to the list of sharing policies.

Updated answers_usage setter to refuse LAUNCHPAD for proprietary products.

Updated _valid_product_information_type to refuse proprietary types if answers_usage is LAUNCHPAD.

Updated Answers configuration to omit LAUNCHPAD option for proprietary products.

Updated makeProduct factory method to use an appropriate license if information_type is proprietary.

== Tests ==
bin/test test_product

== Demo and Q/A ==
Create a PROPRIETARY product. The branch, bug, specification policies should all be PROPRIETARY.

Create an EMBARGOED product. The branch and specification policies should be EMBARGOED_OR_PROPRIETARY, but the bug policy should be PROPRIETARY.

Configure "support tracker". "Launchpad" should not be listed.

= Launchpad lint =

Checking for conflicts and issues in changed files.

Linting changed files:
  lib/lp/app/errors.py
  lib/lp/registry/browser/product.py
  lib/lp/testing/factory.py
  lib/lp/registry/browser/tests/test_product.py
  lib/lp/registry/model/product.py
  lib/lp/registry/tests/test_product.py

[j.c.sackett (jcsackett)]

This looks fine. Please remove the conflict-markers.

review: Approve