Merge lp:~abentley/launchpad/fix-update-cache into lp:launchpad
Status: | Merged |
---|---|
Merged at revision: | 13197 |
Proposed branch: | lp:~abentley/launchpad/fix-update-cache |
Merge into: | lp:launchpad |
Diff against target: |
56 lines (+11/-8) 1 file modified
lib/devscripts/sourcecode.py (+11/-8) |
To merge this branch: | bzr merge lp:~abentley/launchpad/fix-update-cache |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Graham Binns (community) | code | Approve | |
Review via email: mp+63717@code.launchpad.net |
Commit message
Fix stale cache detection
Description of the change
= Summary =
Fix bug #794088: update-sourcecode updates cache when already up-to-date
== Proposed fix ==
Change the check for whether to write the cache so that it is written only if it has changed.
== Pre-implementation notes ==
None
== Implementation details ==
We have to listify the last revision so that it is not a tuple (old cache values have lists, not tuples).
== Tests ==
None
== Demo and Q/A ==
Create a stale branch in sourcecode, e.g. by using "bzr pull --overwrite -r -2"
Run utilities/
The branch will be updated, but the cache file will not be updated, and it will not print a message advising you to commit the cache file.
= Launchpad lint =
Checking for conflicts and issues in changed files.
Linting changed files:
lib/devscript