Merge lp:~abentley/launchpad/fix-expirable-bugs into lp:launchpad

[Aaron Bentley]

Fix +expirable-bugs with dynamic listings.

= Summary =
Fix bug #900398: KeyError: 'mustache_model' in +expirable-bugs page

== Proposed fix ==
Make BugTaskExpirableListingView inherit from BugTaskSearchListingView

== Pre-implementation notes ==
Discussed with deryck

== Implementation details ==
In addition to fixing the bug, this branch also makes +expirable-bugs useful again. Previously, it had listed those bugs which were past the expiry date but not yet expired. This is not very useful, since bugs past the expiry date will be expired by a script within 24 hours and disappear from the listing. It also contradicts the text, and made local testing hard.

== Tests ==
bin/test -t BugTaskExpirableListingView -t test_bugtask -t xx-incomplete-bugs.txt

== Demo and Q/A ==
Ensure you are a member of custom-buglisting-demo

Go to https://bugs.qastaging.launchpad.net/bzr and ensure there's at least one incomplete bug. Click "Incomplete bugs". You should see a list of incomplete bugs in the new style. Log out. You should see a list of incomplete bugs in the old style.

= Launchpad lint =

Checking for conflicts and issues in changed files.

Linting changed files:
  lib/lp/bugs/browser/tests/test_bugtask.py
  lib/lp/bugs/browser/bugtask.py
  lib/lp/bugs/stories/bugs/xx-incomplete-bugs.txt

./lib/lp/bugs/stories/bugs/xx-incomplete-bugs.txt
       1: narrative uses a moin header.
      81: narrative uses a moin header.
     129: narrative uses a moin header.
     221: narrative uses a moin header.
     254: narrative uses a moin header.
     284: want exceeds 78 characters.

[Brad Crittenden (bac)]

Hi Aaron,

Thanks for the clarification on IRC to make up for poor reading comprehension skillz.

typo: dyamic

As usual, nice tests and clear code. Thanks.

review: Approve (code)