Launchpad itself

Merge lp:~abentley/launchpad/enable-tests into lp:launchpad

  1. enable-tests
  2. Merge into devel
Proposed by Aaron Bentley on 2012-07-25
Status: Merged
Merged at revision: 15688
Proposed branch: lp:~abentley/launchpad/enable-tests
Merge into: lp:launchpad
Diff against target: 0 lines
To merge this branch: bzr merge lp:~abentley/launchpad/enable-tests
Reviewer Review Type Date Requested Status
Raphaël Badin (community) 2012-07-25 Approve on 2012-07-25
Francesco Banconi (community) code* 2012-07-25 Approve on 2012-07-25
Review via email: mp+116678@code.launchpad.net

Commit Message

Fix and re-enable test_find_missing_ready

Description of the Change

= Summary =
Fix bug #1018235: TestRunMissingJobs.test_find_missing_ready is disabled due to spurious failures

== Proposed fix ==
Wait until the queue state changes before making assertions about it.

== Pre-implementation notes ==
None

== LOC Rationale ==
I have a LOC credit of 1928

== Implementation details ==
Extract wait_for_queue from test_run_missing_ready_does_not_return_results. Use it in test_find_missing_ready

== Tests ==
bin/test test_celeryjob

== Demo and Q/A ==
None

= Launchpad lint =

Checking for conflicts and issues in changed files.

Linting changed files:
  lib/lp/services/job/tests/test_celeryjob.py

To post a comment you must log in.
Francesco Banconi (frankban) wrote :

Looks good Aaron, thnak you.

review: Approve (code*)
Raphaël Badin (rvb) wrote :

Looks good.

[0]

63 + sleep(1)

I see you haven't changed that but I'm wondering if we shouldn't use a more fine-grained value than one second. I don't have any data to know if this would gain us much but if we're going to use 'wait_for_queue' over and over again, that might be worth checking.

review: Approve

Preview Diff

Empty