Merge lp:~abentley/launchpad/dynamic-listing-robustness into lp:launchpad
| Status: | Merged |
|---|---|
| Merged at revision: | 14296 |
| Proposed branch: | lp:~abentley/launchpad/dynamic-listing-robustness |
| Merge into: | lp:launchpad |
| Diff against target: | 0 lines |
| To merge this branch: | bzr merge lp:~abentley/launchpad/dynamic-listing-robustness |
| Related bugs: |
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| j.c.sackett (community) | Approve | ||
|
Review via email:
|
|||
Commit message
Make dynamic bug listings more robust
Description of the change
= Summary =
Make bug listings more robust by handling error cases better.
== Proposed fix ==
Pop up an error message if IO fails. If the user attempts to go to the "next" or "previous" link when there is none, do nothing.
== Pre-implementation notes ==
Discussed IO handling with deryck
== Implementation details ==
Can't think of anything
== Tests ==
bin/test -t test_buglisting
== Demo and Q/A ==
Enable firebug. On the first set of listings, clicking back should not produce an error message. On the last set of listings, clicking next should not produce an error message.
Disconnect from the Internet. Change the sort ordering. An error message should appear.
= Launchpad lint =
Checking for conflicts and issues in changed files.
Linting changed files:
lib/lp/
lib/lp/
lib/lp/
| Aaron Bentley (abentley) wrote | # |
Aaron--
This looks good. Thanks also for cleaning up the whitespace lint in the test file.