Merge lp:~abentley/launchpad/disable-isolation-test into lp:launchpad

Proposed by Aaron Bentley
Status: Merged
Merged at revision: not available
Proposed branch: lp:~abentley/launchpad/disable-isolation-test
Merge into: lp:launchpad
Prerequisite: lp:launchpad/db-devel
Diff against target: 44 lines (+12/-0)
1 file modified
lib/lp/bugs/externalbugtracker/tests/test_isolation.py (+12/-0)
To merge this branch: bzr merge lp:~abentley/launchpad/disable-isolation-test
Reviewer Review Type Date Requested Status
Brad Crittenden (community) code Approve
Review via email: mp+22458@code.launchpad.net

Commit message

Disable spuriously-failing tests

Description of the change

This branch disables tests that are failing because of ordering issues per bug #551751

To post a comment you must log in.
Revision history for this message
Brad Crittenden (bac) :
review: Approve (code)
Revision history for this message
Deryck Hodge (deryck) wrote :

Aaron, are you going to land this until we can fix this properly?

Revision history for this message
Aaron Bentley (abentley) wrote :

On 04/06/2010 08:37 AM, Deryck Hodge wrote:
> Aaron, are you going to land this until we can fix this properly?

I am having trouble getting the test suite to pass on any of my
machines. On my karmic vm, the appserver dies, and PyGPGME is busted on
Lucid.

Aaron

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== added directory 'lib/canonical/launchpad/apidoc'
2=== modified file 'lib/lp/bugs/externalbugtracker/tests/test_isolation.py'
3--- lib/lp/bugs/externalbugtracker/tests/test_isolation.py 2010-03-18 18:07:26 +0000
4+++ lib/lp/bugs/externalbugtracker/tests/test_isolation.py 2010-04-07 14:06:25 +0000
5@@ -29,6 +29,9 @@
6 stores[0].execute('SELECT 1')
7
8 def test_gen_store_statuses(self):
9+ # XXX: AaronBentley 2010-03-30 bug=551751: Test fails inconsistently.
10+ return
11+
12 # All stores are either disconnected or idle when all
13 # transactions have been aborted.
14 transaction.abort()
15@@ -43,6 +46,9 @@
16 for _, status in isolation.gen_store_statuses()))
17
18 def test_is_transaction_in_progress(self):
19+ # XXX: AaronBentley 2010-03-30 bug=551751: Test fails inconsistently.
20+ return
21+
22 # is_transaction_in_progress() returns False when all
23 # transactions have been aborted.
24 transaction.abort()
25@@ -53,6 +59,9 @@
26 self.failUnless(isolation.is_transaction_in_progress())
27
28 def test_check_no_transaction(self):
29+ # XXX: AaronBentley 2010-03-30 bug=551751: Test fails inconsistently.
30+ return
31+
32 # check_no_transaction() should be a no-op when there are no
33 # transactions in operation.
34 transaction.abort()
35@@ -65,6 +74,9 @@
36 isolation.check_no_transaction)
37
38 def test_ensure_no_transaction(self):
39+ # XXX: AaronBentley 2010-03-30 bug=551751: Test fails inconsistently.
40+ return
41+
42 # ensure_no_transaction() is a decorator that raises
43 # TransactionInProgress if a transaction has begun, else it
44 # simply calls the wrapped function.