Merge lp:~abentley/launchpad/data-download-view into lp:launchpad
|Approved by:||j.c.sackett on 2012-01-26|
|Merged at revision:||14739|
|Diff against target:||
354 lines (+120/-54)
12 files modified
|To merge this branch:||bzr merge lp:~abentley/launchpad/data-download-view|
Description of the Change
= Summary =
Extract DataDownloadView from CodeOfConductDo
== Proposed fix ==
== Pre-implementation notes ==
Discussed Content-type change with sinzui.
== Implementation details ==
Changed Content-Type of downloaded CoC from the fictitious 'application/text' to the standard 'text/plain'. We believe this was a hack to ensure users were prompted to save the CoC, but the Content-disposition of "attachment" achieves this well.
The filename parameter of the Content-disposition header is now always quoted, in compliance with the RFC.
Changed the indentation of a couple of test cases, to fix lint errors.
Subclasses of BaseRdfView must now specify the extension, as well as the rest
of the filename.
== Tests ==
bin/test -t test_codeofconduct -t test_person -t test_product -t xx-productrelea
== Demo and Q/A ==
= Launchpad lint =
Checking for conflicts and issues in changed files.
Linting changed files: