Merge lp:~abentley/launchpad/daily-build-disabled-archive into lp:launchpad

Proposed by Aaron Bentley on 2011-09-13
Status: Merged
Approved by: Aaron Bentley on 2011-09-14
Approved revision: no longer in the source branch.
Merged at revision: 13991
Proposed branch: lp:~abentley/launchpad/daily-build-disabled-archive
Merge into: lp:launchpad
Diff against target: 0 lines
To merge this branch: bzr merge lp:~abentley/launchpad/daily-build-disabled-archive
Reviewer Review Type Date Requested Status
Deryck Hodge (community) code 2011-09-13 Approve on 2011-09-13
Review via email: mp+75239@code.launchpad.net

Commit message

No oops when requesting daily build for a disabled archive.

Description of the change

= Summary =
Fix bug #845846: recipe request daily build fails when the archive is disabled

== Proposed fix ==
We can't build when an archive is disabled, but we can provide a better user experience:
- Do not show the link for a daily build if the archive is disabled.
- If a daily build is requested and the archive is disabled, handle it as a user error.

== Pre-implementation notes ==
None

== Implementation details ==
None

== Tests ==
bin/test test_sourcepackagerecipe -t test_request_daily_builds_disabled_archive -t test_request_daily_builds_button_ppa_disabled

== Demo and Q/A ==
Create a recipe, set up daily builds, navigate to the request-daily-build page.

Disable the archive.

Request a build.

You should get a sane error message.

= Launchpad lint =

Checking for conflicts and issues in changed files.

Linting changed files:
  lib/lp/code/browser/sourcepackagerecipe.py
  lib/lp/code/browser/tests/test_sourcepackagerecipe.py

To post a comment you must log in.
Deryck Hodge (deryck) wrote :

nice, succinct, and good change.

review: Approve (code)

Preview Diff

Empty