Merge lp:~abentley/launchpad/config-disable-build-requests into lp:launchpad

[Aaron Bentley]

= Summary =
With build_from_branch.enabled=False, users cannot navigate to the recipe build
UI, but they can reach it via URL hacking, and the API is unaffected.

== Proposed fix ==
Disable requesting a source package recipe build when
build_from_branch.enabled=False

== Pre-implementation notes ==
Discussed with flacoste and bigjools

== Implementation details ==
This simply raises a ValueError. This may cause an oops in the UI, but I think
this is acceptable because they got there by URL hacking. I want this branch
to be minimal, so that it is acceptable as a cherrypick.

== Tests ==
bin/test -vt requestBuildHonoursConfig test_sourcepackagerecipe

== Demo and Q/A ==
Attempt to request a build on edge or staging. It should fail.

= Launchpad lint =

Checking for conflicts. and issues in doctests and templates.
Running jslint, xmllint, pyflakes, and pylint.
Using normal rules.

Linting changed files:
  lib/lp/code/model/tests/test_sourcepackagerecipe.py
  lib/lp/code/model/sourcepackagerecipe.py

[Paul Hummer (rockstar)]

review: Approve

[Francis J. Lacoste (flacoste)]

review: Approve (release-critical)

[Julian Edwards (julian-edwards)]

Since we had another recipe job take down the build farm this morning, I've landed this branch on devel and production-devel this morning and Tom cherry picked the changes to edge and lpnet.

=== modified file 'lib/lp/code/model/sourcepackagerecipe.py'
--- lib/lp/code/model/sourcepackagerecipe.py	2010-05-28 20:54:57 +0000
+++ lib/lp/code/model/sourcepackagerecipe.py	2010-06-09 15:19:28 +0000
@@ -19,6 +19,7 @@
 from zope.component import getUtility
 from zope.interface import classProvides, implements
 
+from canonical.config import config
 from canonical.database.datetimecol import UtcDateTimeCol
 from canonical.launchpad.interfaces.lpstorm import IMasterStore, IStore
 
@@ -157,6 +158,8 @@
 
     def requestBuild(self, archive, requester, distroseries, pocket):
         """See `ISourcePackageRecipe`."""
+        if not config.build_from_branch.enabled:
+            raise ValueError('Source package recipe builds disabled.')
         if archive.purpose != ArchivePurpose.PPA:
             raise NonPPABuildRequest
         component = getUtility(IComponentSet)["multiverse"]

=== modified file 'lib/lp/code/model/tests/test_sourcepackagerecipe.py'
--- lib/lp/code/model/tests/test_sourcepackagerecipe.py	2010-05-28 20:54:57 +0000
+++ lib/lp/code/model/tests/test_sourcepackagerecipe.py	2010-06-09 15:19:28 +0000
@@ -251,6 +251,15 @@
         self.assertRaises(ArchiveDisabled, recipe.requestBuild, ppa,
                 ppa.owner, distroseries, PackagePublishingPocket.RELEASE)
 
+    def test_requestBuildHonoursConfig(self):
+        recipe = self.factory.makeSourcePackageRecipe()
+        (distroseries,) = list(recipe.distroseries)
+        ppa = self.factory.makeArchive()
+        self.pushConfig('build_from_branch', enabled=False)
+        self.assertRaises(
+            ValueError, recipe.requestBuild, ppa, ppa.owner, distroseries,
+            PackagePublishingPocket.RELEASE)
+
     def test_sourcepackagerecipe_description(self):
         """Ensure that the SourcePackageRecipe has a proper description."""
         description = u'The whoozits and whatzits.'