Merge lp:~abentley/launchpad/broken-xmlrpc-lookup into lp:launchpad
Status: | Merged | ||||||||
---|---|---|---|---|---|---|---|---|---|
Approved by: | Aaron Bentley | ||||||||
Approved revision: | no longer in the source branch. | ||||||||
Merged at revision: | 15654 | ||||||||
Proposed branch: | lp:~abentley/launchpad/broken-xmlrpc-lookup | ||||||||
Merge into: | lp:launchpad | ||||||||
Diff against target: |
118 lines (+19/-28) 4 files modified
lib/lp/app/browser/tests/test_launchpad.py (+8/-9) lib/lp/code/interfaces/branchlookup.py (+0/-2) lib/lp/code/model/branchlookup.py (+8/-6) lib/lp/code/model/tests/test_branchlookup.py (+3/-11) |
||||||||
To merge this branch: | bzr merge lp:~abentley/launchpad/broken-xmlrpc-lookup | ||||||||
Related bugs: |
|
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Deryck Hodge (community) | Approve | ||
Review via email: mp+115582@code.launchpad.net |
Commit message
Fix +branch/product handling in xmlrpc & loggerhead.
Description of the change
= Summary =
Fix bug #1025368: Codehosting xmlrpc not handling project with trailing path
== Proposed fix ==
Change getByLPPath to handle ProductSeries traversal failures by looking up as a Product.
== Pre-implementation notes ==
Discussed the inherent abiguity of +branch aliases with deryck
== LOC Rationale ==
Removes 9 lines.
== Implementation details ==
Removed stale comments (some support for trailing paths had already been added.)
Special-casing for .bzr pathnames can be removed, since now all paths under a product will fall back to the product if there is no such ProductSeries.
== Tests ==
bin/test -t test_alias_
== Demo and Q/A ==
Go to https:/
You should see the normal Loggerhead view for a branch. (The same as https:/
= Launchpad lint =
Checking for conflicts and issues in changed files.
Linting changed files:
lib/lp/
lib/lp/
lib/lp/
lib/lp/