Launchpad itself

Merge lp:~abentley/launchpad/blueprint-info-type-code into lp:launchpad

  1. blueprint-info-type-code
  2. Merge into devel
Proposed by Aaron Bentley on 2012-08-28
Status: Merged
Approved by: Aaron Bentley on 2012-08-28
Approved revision: no longer in the source branch.
Merged at revision: 15872
Proposed branch: lp:~abentley/launchpad/blueprint-info-type-code
Merge into: lp:launchpad
Prerequisite: lp:~abentley/launchpad/blueprint-info-type-idx
Diff against target: 27 lines (+2/-3)
2 files modified
lib/lp/blueprints/interfaces/specification.py (+2/-2)
lib/lp/blueprints/model/specification.py (+0/-1)
To merge this branch: bzr merge lp:~abentley/launchpad/blueprint-info-type-code
Reviewer Review Type Date Requested Status
Richard Harding (community) 2012-08-28 Approve on 2012-08-28
Aaron Bentley (community) Abstain on 2012-08-28
Stuart Bishop 2012-08-28 Pending
Review via email: mp+121683@code.launchpad.net

Commit Message

Tweak implementation of Specification.information_type

Description of the Change

= Summary =
Tweak the model code and garbo job for Specification.information_type

== Pre-implementation notes ==
None

== LOC Rationale ==
Part of Private projects

== Implementation details ==
Specification already had a .private member, which abel has masked with a property. Since this member is unused, we can simply drop it (and later, the column).

This also fixes the documentation and default for the interface.

== Tests ==
None

== Demo and Q/A ==
None

= Launchpad lint =

Checking for conflicts and issues in changed files.

Linting changed files:
  database/schema/patch-2209-28-1.sql
  database/schema/comments.sql
  database/schema/security.cfg
  lib/lp/scripts/garbo.py
  lib/lp/blueprints/model/specification.py
  lib/lp/scripts/tests/test_garbo.py
  database/schema/patch-2209-28-2.sql
  lib/lp/blueprints/interfaces/specification.py

To post a comment you must log in.
Aaron Bentley (abentley) :
review: Abstain
Richard Harding (rharding) :
review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'lib/lp/blueprints/interfaces/specification.py'
2--- lib/lp/blueprints/interfaces/specification.py 2012-08-20 16:38:10 +0000
3+++ lib/lp/blueprints/interfaces/specification.py 2012-08-28 19:16:47 +0000
4@@ -158,9 +158,9 @@
5 information_type = exported(
6 Choice(
7 title=_('Information Type'), vocabulary=InformationType,
8- required=True, readonly=True,
9+ required=True, readonly=True, default=InformationType.PUBLIC,
10 description=_(
11- 'The type of information contained in this bug report.')))
12+ 'The type of information contained in this specification.')))
13
14 def userCanView(user):
15 """Return True if `user` can see this ISpecification, false otherwise.
16
17=== modified file 'lib/lp/blueprints/model/specification.py'
18--- lib/lp/blueprints/model/specification.py 2012-08-20 16:38:10 +0000
19+++ lib/lp/blueprints/model/specification.py 2012-08-28 19:16:47 +0000
20@@ -147,7 +147,6 @@
21 dbName='owner', foreignKey='Person',
22 storm_validator=validate_public_person, notNull=True)
23 datecreated = UtcDateTimeCol(notNull=True, default=DEFAULT)
24- private = BoolCol(notNull=True, default=False)
25 product = ForeignKey(dbName='product', foreignKey='Product',
26 notNull=False, default=None)
27 productseries = ForeignKey(dbName='productseries',