Merge lp:~abentley/launchpad/blueprint-info-type-change into lp:launchpad

Proposed by Aaron Bentley on 2012-09-04
Status: Merged
Approved by: Aaron Bentley on 2012-09-04
Approved revision: no longer in the source branch.
Merged at revision: 15911
Proposed branch: lp:~abentley/launchpad/blueprint-info-type-change
Merge into: lp:launchpad
Prerequisite: lp:~abentley/launchpad/blueprint-info-type-ui
Diff against target: 0 lines
To merge this branch: bzr merge lp:~abentley/launchpad/blueprint-info-type-change
Reviewer Review Type Date Requested Status
Richard Harding (community) 2012-09-04 Approve on 2012-09-04
Review via email: mp+122753@code.launchpad.net

Commit Message

Enable setting information_type via browser.

Description of the Change

= Summary =
Support setting Specification.information_type via the browser

== Pre-implementation notes ==
Discussed with deryck

== LOC Rationale ==
Part of Private Projects

== Implementation details ==
This operation currently returns '', but will eventually return subscription information, as bugs do. Modifying a Specification's information_type but returning subscriber information is page-specific functionality and makes no particular sense in an API, so it is provided via the appservers, rather than the API.

The tests use create_initialized_view because this permits setting the HTTP_X_REQUESTED_WITH header, which allows for standard error handling.

== Tests ==
bin/test test_specification

== Demo and Q/A ==
Set the 'blueprints.information_type.enabled' feature flag to "on".

Change the information_type of a blueprint. It should succeed. Reload the page. The new information_type should be retained.

= Launchpad lint =

Checking for conflicts and issues in changed files.

Linting changed files:
  lib/lp/blueprints/templates/specification-index.pt
  lib/lp/app/javascript/information_type.js
  lib/lp/blueprints/templates/blueprint-portlet-privacy.pt
  lib/lp/testing/factory.py
  lib/lp/app/javascript/tests/test_information_type.js
  lib/lp/testing/__init__.py
  lib/lp/blueprints/model/tests/test_specification.py
  lib/lp/blueprints/tests/test_specification.py
  lib/lp/blueprints/model/specification.py
  lib/lp/bugs/javascript/bugtask_index.js
  lib/lp/services/features/flags.py
  lib/lp/blueprints/browser/configure.zcml
  lib/lp/blueprints/browser/specification.py
  lib/lp/blueprints/browser/tests/test_specification.py
  lib/lp/app/javascript/tests/test_information_type.html
  lib/lp/blueprints/templates/bug-secrecy.pt
  lib/lp/blueprints/interfaces/specification.py

To post a comment you must log in.
Richard Harding (rharding) :
review: Approve

Preview Diff

Empty