Merge lp:~abentley/juju-ci-tools/jujupy-reorg3 into lp:juju-ci-tools

Proposed by Aaron Bentley
Status: Merged
Merged at revision: 1903
Proposed branch: lp:~abentley/juju-ci-tools/jujupy-reorg3
Merge into: lp:juju-ci-tools
Prerequisite: lp:~abentley/juju-ci-tools/jujupy-reorg2
Diff against target: 58 lines (+16/-4)
4 files modified
jujupy/timeout.py (+1/-1)
jujupy/utility.py (+2/-2)
jujupy/version_client.py (+1/-1)
setup.py (+12/-0)
To merge this branch: bzr merge lp:~abentley/juju-ci-tools/jujupy-reorg3
Reviewer Review Type Date Requested Status
Curtis Hovey (community) code Approve
Review via email: mp+318036@code.launchpad.net

Commit message

Turn jujupy into a standalone library.

Description of the change

This branch completes turning jujupy into a standalone library.

It moves timeout into jujupy, fixes some imports, and adds a setup.py.

I have successfully used this version with Hammer Time.

To post a comment you must log in.
Revision history for this message
Curtis Hovey (sinzui) wrote :

Thank you.

review: Approve (code)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== renamed file 'tests/test_timeout.py' => 'jujupy/tests/test_timeout.py'
2=== renamed file 'timeout.py' => 'jujupy/timeout.py'
3--- timeout.py 2015-08-19 15:07:08 +0000
4+++ jujupy/timeout.py 2017-02-22 21:42:28 +0000
5@@ -7,7 +7,7 @@
6 import sys
7 import time
8
9-from utility import until_timeout
10+from jujupy.utility import until_timeout
11
12
13 # Generate a list of all signals that can be used with Popen.send_signal on
14
15=== modified file 'jujupy/utility.py'
16--- jujupy/utility.py 2017-02-22 21:42:27 +0000
17+++ jujupy/utility.py 2017-02-22 21:42:28 +0000
18@@ -178,8 +178,8 @@
19
20
21 def get_timeout_path():
22- import timeout
23- return os.path.abspath(timeout.__file__)
24+ import jujupy.timeout
25+ return os.path.abspath(jujupy.timeout.__file__)
26
27
28 def unqualified_model_name(model_name):
29
30=== modified file 'jujupy/version_client.py'
31--- jujupy/version_client.py 2017-02-10 07:27:57 +0000
32+++ jujupy/version_client.py 2017-02-22 21:42:28 +0000
33@@ -28,7 +28,7 @@
34 unqualified_model_name,
35 UpgradeMongoNotSupported,
36 )
37-from utility import (
38+from jujupy.utility import (
39 ensure_deleted,
40 scoped_environ,
41 split_address_port,
42
43=== added file 'setup.py'
44--- setup.py 1970-01-01 00:00:00 +0000
45+++ setup.py 2017-02-22 21:42:28 +0000
46@@ -0,0 +1,12 @@
47+from setuptools import setup
48+setup(
49+ name='jujupy',
50+ version='0.1.0',
51+ description='A library for driving the Juju client.',
52+ packages=['jujupy'],
53+ install_requires=[
54+ 'python-dateutil >= 2',
55+ 'pexpect >= 4.0.0',
56+ 'PyYAML >= 3.0',
57+ ]
58+ )

Subscribers

People subscribed via source and target branches