Merge lp:~abentley/ci-director/reduce-verbosity into lp:ci-director

[Aaron Bentley]

Reduce the verbosity of start-builds and update-outcome.

Reduce verbosity of update-outcome and start-builds

This branch reduces the verbosity of update-outcome and start-builds at the INFO level. It moves most of the notifications to the DEBUG level.

Since individual scans will no longer be visible at the INFO level, it introduces "Scanning for new and updated builds." at the beginning and "Scan complete." at the end.

[lp:~abentley/ci-director/reduce-verbosity]

183. By Aaron Bentley on 2016-08-29

Reduce the verbosity of start-builds and update-outcome.

[Aaron Bentley (abentley)]

Committed and pushed.

[Curtis Hovey (sinzui)]

Thank you.

review: Approve (code)

=== modified file 'cidirector/start_builds.py'
--- cidirector/start_builds.py	2016-08-26 19:02:14 +0000
+++ cidirector/start_builds.py	2016-08-29 15:47:06 +0000
@@ -53,10 +53,10 @@
     unsatisfied_prerequisites = {}
     for job in pending:
         if job.test_id in active_jobs:
-            logging.info('{} already active.'.format(job.test_id))
+            logging.debug('{} already active.'.format(job.test_id))
             continue
         if job.test_id not in enabled_jobs:
-            logging.info('{} not enabled.'.format(job.test_id))
+            logging.debug('{} not enabled.'.format(job.test_id))
             continue
         blockers = [p for p in job.prerequisite_jobs
                     if jobs[p].status != SUCCEEDED]
@@ -68,12 +68,12 @@
         active_buildable = active_jobs.union(buildable)
         active_conflicts = active_buildable.intersection(job.conflicts)
         if len(active_conflicts) > 0:
-            logging.info('{} conflicts: ({})'.format(job.test_id, ', '.join(
+            logging.debug('{} conflicts: ({})'.format(job.test_id, ', '.join(
                 active_conflicts)))
             continue
         buildable.add(job.test_id)
     for blocker, blocked in sorted(unsatisfied_prerequisites.items()):
-        logging.info('Prereq "{}" prevents: {}'.format(
+        logging.debug('Prereq "{}" prevents: {}'.format(
             blocker, ', '.join(sorted(blocked))))
     return buildable, {p.test_id for p in pending}
 

=== modified file 'cidirector/update_outcome.py'
--- cidirector/update_outcome.py	2016-08-29 15:09:47 +0000
+++ cidirector/update_outcome.py	2016-08-29 15:47:06 +0000
@@ -85,13 +85,13 @@
     info = jenkins.get_info()
     for job in info['jobs']:
         job_name = job['name']
-        logging.info('Scanning {}'.format(job_name))
+        logging.debug('Scanning {}'.format(job_name))
         job_last = last_completed.get(job_name)
         job_info = jenkins.get_job_info(job_name)
         config = get_cid_config(job_info)
         if job_name != BUILD_REVISION and config is None:
             if get_cid_config(job_info, cloud_health=True) is None:
-                logging.info('Skipping {}; no ci-director config'.format(
+                logging.debug('Skipping {}; no ci-director config'.format(
                              job_name))
                 continue
         builds = sorted(b['number'] for b in job_info['builds'])
@@ -101,7 +101,7 @@
 
 def iter_build_info(jenkins, job_name, builds):
     for build in builds:
-        logging.info('Scanning {} #{}'.format(job_name, build))
+        logging.debug('Scanning {} #{}'.format(job_name, build))
         yield jenkins.get_build_info(job_name, build)
 
 
@@ -167,6 +167,7 @@
     new_last_completed = {}
     revision_build_jobs = {}
     cloud_jobs = {}
+    logging.info('Scanning for new and updated builds.')
     for job_info, builds in iter_job_builds(jenkins, last_completed):
         is_cloud = bool(get_cid_config(job_info, cloud_health=True) is not
                         None)
@@ -201,6 +202,7 @@
             builds[str(build_info['number'])] = build_info
     update_job_configs(revision_build_jobs, by_revision_build)
     update_job_configs(cloud_jobs, cloud_health)
+    logging.info('Scan complete.')
     return by_revision_build, cloud_health, new_last_completed