lp:~abentley/charmworld/remove-018-migration
- Get this branch:
- bzr branch lp:~abentley/charmworld/remove-018-migration
Branch merges
- Juju Gui Bot: Approve (continuous-integration)
- Brad Crittenden (community): Approve (code)
-
Diff: 102 lines (+7/-76)2 files modifiedcharmworld/migrations/versions/018_delete_all_bundles.py (+0/-18)
charmworld/migrations/versions/tests/test_migrations.py (+7/-58)
Branch information
Recent revisions
- 430. By Benji York
-
Add handling for "-HEAD" revisions to API2
R=bac
CC=
https://codereview. appspot. com/16950043 - 429. By Brad Crittenden
-
Add changelog to bundle page.
R=benji
CC=
https://codereview. appspot. com/16690043 - 427. By Benji York
-
Add recent bzr changes to bundles.
R=bac
CC=
https://codereview. appspot. com/15100046 - 426. By Richard Harding
-
Refactory the proof api to be it's own module.
- Break out the proof api bits into a new api module vs the same api file.
- Move tests and fix to match
- Remove the model in the lib bits and try to keep things in views/models.Approved by Juju Gui Bot.
- 425. By Brad Crittenden
-
Parse charms with hyphens properly.
R=benji
CC=
https://codereview. appspot. com/15580047 - 424. By Richard Harding
-
Add charm config proofing and update api response
- Move proof logic into a new lib/proof.py module
- Update the proof api call to look through the bundles and proof them
- Change errors to be catchable exceptions, the exception contains both a msg
and debug_info we expose via the api call
- Update the api call to provide a summary error_messages (for Marco's needs)
but keep the details in the actual list of errors with the messages and the
debug info we have that went into those errors.Sample proof api call and response:
http://paste.mitechie. com/show/ 1049/ Note: this is only adding the new proof checks of validating the
config/options from the charm found in the database to the options defined in
the bundle.- Validate the option exists in the charm we found in the db
- Validate that the type is of the correct type.
- Validate that the charm we found has options at all.QA
---
You have to ingest the charms so that we can validate them. You can then toss
the yaml file (as a single string) to the proof api endpoint as a POST'd key
deployer_file. Right now it only handles yaml.
Branch metadata
- Branch format:
- Branch format 7
- Repository format:
- Bazaar repository format 2a (needs bzr 1.16 or later)
- Stacked on:
- lp:~juju-jitsu/charmworld/trunk