Merge lp:~abentley/charms/precise/juju-reports/charm-bundle-test-token into lp:~juju-qa/charms/precise/juju-reports/trunk

Proposed by Aaron Bentley
Status: Merged
Merged at revision: 41
Proposed branch: lp:~abentley/charms/precise/juju-reports/charm-bundle-test-token
Merge into: lp:~juju-qa/charms/precise/juju-reports/trunk
Diff against target: 42 lines (+8/-2)
2 files modified
config.yaml (+4/-0)
hooks/common.py (+4/-2)
To merge this branch: bzr merge lp:~abentley/charms/precise/juju-reports/charm-bundle-test-token
Reviewer Review Type Date Requested Status
Curtis Hovey (community) code Approve
Review via email: mp+230351@code.launchpad.net

Commit message

Add charm-bundle-test-token config option.

Description of the change

This branch implements a charm-bundle-test-token config value, so that the juju-reports machine can trigger builds of charm-bundle-test.

To post a comment you must log in.
Revision history for this message
Curtis Hovey (sinzui) wrote :

Thank you.

review: Approve (code)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'config.yaml'
2--- config.yaml 2014-07-18 20:19:59 +0000
3+++ config.yaml 2014-08-11 16:43:59 +0000
4@@ -48,3 +48,7 @@
5 type: string
6 default: ""
7 description: "The secret key to use for the s3 bucket."
8+ charm-bundle-test-token:
9+ type: string
10+ default: ""
11+ description: "The build token for the charm-bundle-test job."
12
13=== modified file 'hooks/common.py'
14--- hooks/common.py 2014-07-22 16:35:33 +0000
15+++ hooks/common.py 2014-08-11 16:43:59 +0000
16@@ -34,7 +34,7 @@
17 return os.path.join(PROJECT_DIR, 'resources/{}.template'.format(name))
18
19
20-def install_ini(mongo_url, gh_token, jujuci_url):
21+def install_ini(mongo_url, gh_token, jujuci_url, token):
22 config = ConfigParser()
23 path = get_template_path(INI)
24 if not os.path.exists(path):
25@@ -43,6 +43,7 @@
26 config.set('app:main', 'mongo.url', mongo_url)
27 config.set('app:main', 'gh_token', gh_token)
28 config.set('app:main', 'jujuci.url', jujuci_url)
29+ config.set('app:main', 'charm_bundle_test_token', token)
30 config.set('app:main', 'home', HOME)
31 config.write(open(get_ini_path(), 'w'))
32 return config
33@@ -257,7 +258,8 @@
34 if mongo_url == '':
35 hookenv.log('No mongodb set up.')
36 return
37- ini = install_ini(mongo_url, config['gh-token'], config['jujuci-url'])
38+ ini = install_ini(mongo_url, config['gh-token'], config['jujuci-url'],
39+ config['charm-bundle-test-token'])
40 configure_s3(config)
41 for key in ['lp-key', 'lp-oauth', 'gh-token']:
42 if config[key] == '':

Subscribers

People subscribed via source and target branches

to all changes: