Code review comment for lp:~abentley/bzr/send-hookage

Revision history for this message
Aaron Bentley (abentley) wrote :

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Hi all,

This patch adds a new MergeDirective hook to calculate the message body.
 This helps projects with a specific review template, like Launchpad, to
ensure the template is considered for all reviews.

It does this by moving the mail_client-specific functionality of
cmd_send into the new MergeDirective.compose_merge_request method.
There is a similarly-named method on MailClient, but this receives a
MergeDirective that has already been serialized, and for the hook, live
objects are more useful.

As well as the Branch and directive, this method also takes an optional
Tree parameter. This will typically be the WorkingTree that the user
ran 'bzr send' against. This may be useful for hooks that want to
examine the working tree to generate the body. Launchpad, for example,
runs 'lint' against files which have changed.

Aaron
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iEYEARECAAYFAkoIh8cACgkQ0F+nu1YWqI1KPACeNrcy/bMN+CqdgEjOnA5rNJKl
eGQAn1hIvbNAj7PUUgZRGqMM8NJlMPB0
=biQr
-----END PGP SIGNATURE-----

« Back to merge proposal