Merge lp:~abentley/bzr/find-proposal-revid into lp:bzr
Status: | Merged |
---|---|
Merged at revision: | 6541 |
Proposed branch: | lp:~abentley/bzr/find-proposal-revid |
Merge into: | lp:bzr |
Prerequisite: | lp:~abentley/bzr/lucid-launchpadlib |
Diff against target: |
147 lines (+24/-53) 3 files modified
bzrlib/plugins/launchpad/cmds.py (+16/-47) bzrlib/plugins/launchpad/lp_api.py (+3/-2) doc/en/release-notes/bzr-2.6.txt (+5/-4) |
To merge this branch: | bzr merge lp:~abentley/bzr/find-proposal-revid |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Martin Packman (community) | Approve | ||
Aaron Bentley | Pending | ||
Review via email: mp+116276@code.launchpad.net |
This proposal supersedes a proposal from 2012-07-20.
Description of the change
This branch changes the lp-find-proposal logic to use only the revision-id (not
revno and branch) to look up merge proposals.
Since the previous version used the branch in and revno API requests, it meant that lp-find-proposal only worked when the correct branch was specified. This way, it works no matter how the revision-id is determined.
The old code also required that the revision was on the mainline of the current branch, so for non-mainline revisions, it found the mainline revision that merged them. This code doesn't do that, but the user can prefix their revision spec with "mainline:" to restore that behaviour if it is desirable.
Nice simplification. Wants a news entry given the slight behaviour change I'd say.
+ version='devel')
If there's ever going to be another 'release' of the launchpad api, a comment here saying "getMergePropos als(merged_ revision= ) not in 1.0" would be good.