Bazaar

Code review comment for lp:~abentley/bzr/disk-transform

  1. disk-transform
  2. Merge into trunk-old
Revision history for this message
Ian Clatworthy (ian-clatworthy) wrote :

All looks good to me. Two minor things:

1. Please tweak the docstring for TreeTransformBase so it doesn't claim to be a base class for itself. :-)

2. You're changing the constructor interface for TreeTransformBase which is technically public (but practically private). I think we should therefore mention this refactoring in the Internals sections of NEWS.

review: Approve

« Back to merge proposal