Code review comment for lp:~abentley/bzr-pqm/lpland

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Robert Collins wrote:
> Review: Approve
> This may seem nitpicky:
> + """
> + Land the merge proposal for this branch via PQM.
> ...
>
> That adds a leading line to the docstring and thus to the help, I think. So please do
> """Land ....
> instead.

Done.

> What happens if there are multiple outstanding proposals - does it error or take an arbitrary one?

It errors, but in that case you can specify the specific proposal you
want to land. I've updated the docstring.

> The
> +# XXX: JonathanLange 2009-09-24: Bo
>
> todo looks like its probably trivially available?

Not on my laptop with launchpadlib 1.5.1.

> If not thats fine, but if we can action it lets do that now.
>
> 602 +
> 603 +
> 604 +def test_suite():
> 605 + return unittest.TestLoader().loadTestsFromName(__name__)
>
> at the bottom of the test script is not idiomatic for bzr.

Removed.

Aaron
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iEYEARECAAYFAktY3zIACgkQ0F+nu1YWqI2fqQCeKUBrivCDapUgLhaAmEvUZc+s
p68Anip1gWcOcPAF0tTfwJLnhrTM31sF
=PJhQ
-----END PGP SIGNATURE-----