Merge lp:~abentley/bzr-loom/merge-1 into lp:~launchpad-pqm/bzr-loom/trunk

Proposed by Aaron Bentley
Status: Merged
Merge reported by: Robert Collins
Merged at revision: not available
Proposed branch: lp:~abentley/bzr-loom/merge-1
Merge into: lp:~launchpad-pqm/bzr-loom/trunk
Diff against target: None lines
To merge this branch: bzr merge lp:~abentley/bzr-loom/merge-1
Reviewer Review Type Date Requested Status
Paul Hummer (community) Approve
Review via email: mp+5795@code.launchpad.net
To post a comment you must log in.
Revision history for this message
Aaron Bentley (abentley) wrote :

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

 reviewer rockstar

This patch makes bzr-loom compatible with both 1.13 and 1.14. This
allows us to upgrade bzr-loom, and then upgrade bzr. The version in
bzr-loom's trunk is not compatible with 1.13.

Aaron
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iEYEARECAAYFAknvTm4ACgkQ0F+nu1YWqI0tOACeM2699U1+AefWnA3mDvKgppjx
TtEAn00/91RAsJXd2CiqcdV8FBKNG6gB
=7DK3
-----END PGP SIGNATURE-----

Revision history for this message
Paul Hummer (rockstar) :
review: Approve
Revision history for this message
Paul Hummer (rockstar) wrote :

Can we get this merged?

Revision history for this message
Vincent Ladeuil (vila) wrote :

lp can't access this branch and AFAICS the relevant change is in trunk anyway, so I'm going to mark this merge proposal merged.

Revision history for this message
Vincent Ladeuil (vila) wrote :

Doh. Except I can't do that for lack of... permissions ? The pencil icon is nowhere to be seen near the status...

Revision history for this message
Robert Collins (lifeless) wrote :

Marking merge as per Vincent's discussion.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'branch.py'
2--- branch.py 2009-02-28 11:02:28 +0000
3+++ branch.py 2009-04-22 16:55:43 +0000
4@@ -801,7 +801,7 @@
5 control_files.unlock()
6 return self.open(a_bzrdir, _found=True, )
7
8- def open(self, a_bzrdir, _found=False):
9+ def open(self, a_bzrdir, _found=False, ignore_fallbacks=False):
10 """Return the branch object for a_bzrdir
11
12 _found is a private parameter, do not use it. It is used to indicate
13@@ -813,10 +813,15 @@
14 transport = a_bzrdir.get_branch_transport(None)
15 control_files = bzrlib.lockable_files.LockableFiles(
16 transport, 'lock', bzrlib.lockdir.LockDir)
17+ if ignore_fallbacks:
18+ kwargs = {'ignore_fallbacks': True}
19+ else:
20+ kwargs = {}
21 return self._branch_class(_format=self,
22 _control_files=control_files,
23 a_bzrdir=a_bzrdir,
24- _repository=a_bzrdir.find_repository())
25+ _repository=a_bzrdir.find_repository(),
26+ **kwargs)
27
28 def take_over(self, branch):
29 """Take an existing bzrlib branch over into Loom format.

Subscribers

People subscribed via source and target branches