Merge lp:~abelloni/ubuntu-themes/3.8_fixes into lp:ubuntu-themes

Proposed by Alexandre BELLONI
Status: Merged
Approved by: Mathieu Trudel-Lapierre
Approved revision: 285
Merged at revision: 288
Proposed branch: lp:~abelloni/ubuntu-themes/3.8_fixes
Merge into: lp:ubuntu-themes
Diff against target: 29 lines (+8/-0)
2 files modified
Ambiance/gtk-3.0/apps/nautilus.css (+4/-0)
Radiance/gtk-3.0/apps/nautilus.css (+4/-0)
To merge this branch: bzr merge lp:~abelloni/ubuntu-themes/3.8_fixes
Reviewer Review Type Date Requested Status
PS Jenkins bot (community) continuous-integration Approve
Mathieu Trudel-Lapierre Approve
Jeremy Bicha Abstain
Dmitry Shachnev Approve
Review via email: mp+161439@code.launchpad.net

Commit message

Fix desktop background not showing (LP: #1159430)

Description of the change

Fix desktop background not showing (LP: #1159430)

To post a comment you must log in.
Revision history for this message
Dmitry Shachnev (mitya57) wrote :

Thanks for your work, there are some issues:

- use spaces, not tabs;
- please commit with --fixes lp:1159430 to get a changelog entry.

Revision history for this message
Dmitry Shachnev (mitya57) :
review: Needs Fixing
Revision history for this message
Dmitry Shachnev (mitya57) wrote :

Looks fine to me now.

review: Approve
Revision history for this message
Dmitry Shachnev (mitya57) wrote :

Jeremy or Didier, any chance you could approve this?

Revision history for this message
Jeremy Bicha (jbicha) wrote :

Dmitry, sorry, I've never done merge approvals or uploads for the new Unity daily-build style packages, nor do I consider myself a ubuntu-themes maintainer so I don't think I'm the right person for this.

review: Abstain
Revision history for this message
Mathieu Trudel-Lapierre (cyphermox) wrote :

Seems broken to me here; I get a black background in nautilus after navigating a few directories.

Marking Needs Fixing for now, but I'll take a look and try to figure out what's up.

review: Needs Fixing
Revision history for this message
Alexandre BELLONI (abelloni) wrote :

Fixed now by restricting the transparent background to NautilusDesktopWindow as suggested by Denis Gorodnichev

Revision history for this message
Mathieu Trudel-Lapierre (cyphermox) wrote :

Seems fine, it doesn't break my desktop (I don't have the new nautilus) and things seem to work properly.

review: Approve
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

FAILED: Autolanding.
No commit message was specified in the merge proposal. Hit 'Add commit message' on the merge proposal web page or follow the link below. You can approve the merge proposal yourself to rerun.
https://code.launchpad.net/~abelloni/ubuntu-themes/3.8_fixes/+merge/161439/+edit-commit-message

review: Needs Fixing (continuous-integration)
Revision history for this message
PS Jenkins bot (ps-jenkins) :
review: Approve (continuous-integration)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'Ambiance/gtk-3.0/apps/nautilus.css'
2--- Ambiance/gtk-3.0/apps/nautilus.css 2012-08-09 16:56:13 +0000
3+++ Ambiance/gtk-3.0/apps/nautilus.css 2013-05-22 17:22:36 +0000
4@@ -4,6 +4,10 @@
5 -GtkPaned-handle-size: 1;
6 }
7
8+NautilusDesktopWindow GtkWidget {
9+ background-color: @transparent;
10+}
11+
12 .nautilus-canvas-item {
13 border-radius: 4px;
14 }
15
16=== modified file 'Radiance/gtk-3.0/apps/nautilus.css'
17--- Radiance/gtk-3.0/apps/nautilus.css 2012-08-09 16:56:13 +0000
18+++ Radiance/gtk-3.0/apps/nautilus.css 2013-05-22 17:22:36 +0000
19@@ -4,6 +4,10 @@
20 -GtkPaned-handle-size: 1;
21 }
22
23+NautilusDesktopWindow GtkWidget {
24+ background-color: @transparent;
25+}
26+
27 .nautilus-canvas-item {
28 border-radius: 4px;
29 }

Subscribers

People subscribed via source and target branches