Merge lp:~aauzi/midori/fix-bookmarks-tests-regression into lp:midori

Proposed by André Auzi
Status: Merged
Approved by: Cris Dywan
Approved revision: 6413
Merged at revision: 6417
Proposed branch: lp:~aauzi/midori/fix-bookmarks-tests-regression
Merge into: lp:midori
Diff against target: 38 lines (+5/-5)
1 file modified
midori/midori-bookmarks-db.c (+5/-5)
To merge this branch: bzr merge lp:~aauzi/midori/fix-bookmarks-tests-regression
Reviewer Review Type Date Requested Status
Cris Dywan Approve
Review via email: mp+187916@code.launchpad.net

Commit message

fix bookmarks test regression after fix-1179200-4

To post a comment you must log in.
Revision history for this message
Cris Dywan (kalikiana) wrote :

Thanks for the fix!

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'midori/midori-bookmarks-db.c'
2--- midori/midori-bookmarks-db.c 2013-09-17 19:34:23 +0000
3+++ midori/midori-bookmarks-db.c 2013-09-26 21:03:27 +0000
4@@ -132,7 +132,7 @@
5 {
6 bookmarks->db = NULL;
7
8- katze_item_set_meta_integer (KATZE_ITEM (bookmarks), "id", 0);
9+ katze_item_set_meta_integer (KATZE_ITEM (bookmarks), "id", -1);
10 katze_item_set_name (KATZE_ITEM (bookmarks), _("Bookmarks"));
11 /* g_object_ref (bookmarks); */
12 }
13@@ -203,21 +203,21 @@
14
15 db_parent = midori_bookmarks_db_get_item_parent (bookmarks, item);
16
17- g_return_if_fail (db_parent);
18-
19 if (parent == db_parent)
20 {
21 if (IS_MIDORI_BOOKMARKS_DB (parent))
22 KATZE_ARRAY_CLASS (midori_bookmarks_db_parent_class)->update (parent);
23- else
24+ else if (KATZE_IS_ARRAY (parent))
25 katze_array_update (parent);
26 return;
27 }
28
29 if (IS_MIDORI_BOOKMARKS_DB (parent))
30 KATZE_ARRAY_CLASS (midori_bookmarks_db_parent_class)->add_item (parent, item);
31- else
32+ else if (KATZE_IS_ARRAY (parent))
33 katze_array_add_item (parent, item);
34+
35+ g_assert (parent == katze_item_get_parent (KATZE_ITEM (item)));
36 }
37
38 /**

Subscribers

People subscribed via source and target branches

to all changes: