Merge lp:~aauzi/midori/fix-1179200-1 into lp:midori

Proposed by André Auzi
Status: Merged
Approved by: Cris Dywan
Approved revision: 6320
Merged at revision: 6346
Proposed branch: lp:~aauzi/midori/fix-1179200-1
Merge into: lp:midori
Diff against target: 25 lines (+6/-6)
1 file modified
midori/midori-array.c (+6/-6)
To merge this branch: bzr merge lp:~aauzi/midori/fix-1179200-1
Reviewer Review Type Date Requested Status
gue5t gue5t Approve
Review via email: mp+178495@code.launchpad.net

Commit message

Fix name and text fields inversion in XBEL folder import

Description of the change

Here is the first of a few helpers steps for merge of fix-1179200.

It fixes an inversion detected when testing bookmarks import speed up resulting from the use of database transactions.

To post a comment you must log in.
Revision history for this message
gue5t gue5t (gue5t) wrote :

As far as I can tell this is good; in testing it on http://xbel.sourceforge.net/bookmarks/xbel.xbel it seemed to result in correct import behavior while unpatched midori did not.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'midori/midori-array.c'
2--- midori/midori-array.c 2013-05-30 21:57:04 +0000
3+++ midori/midori-array.c 2013-08-05 05:48:23 +0000
4@@ -97,15 +97,15 @@
5 if (katze_str_equal ((gchar*)cur->name, "title"))
6 {
7 gchar* value = g_strstrip ((gchar*)xmlNodeGetContent (cur));
8+ katze_item_set_name (KATZE_ITEM (array), value);
9+ xmlFree (value);
10+ }
11+ else if (katze_str_equal ((gchar*)cur->name, "desc"))
12+ {
13+ gchar* value = g_strstrip ((gchar*)xmlNodeGetContent (cur));
14 katze_item_set_text (KATZE_ITEM (array), value);
15 xmlFree (value);
16 }
17- else if (katze_str_equal ((gchar*)cur->name, "desc"))
18- {
19- gchar* value = g_strstrip ((gchar*)xmlNodeGetContent (cur));
20- katze_item_set_name (KATZE_ITEM (array), value);
21- xmlFree (value);
22- }
23 else if (katze_str_equal ((gchar*)cur->name, "info"))
24 katze_xbel_parse_info ((KatzeItem*)array, cur);
25 else if (katze_str_equal ((gchar*)cur->name, "folder"))

Subscribers

People subscribed via source and target branches

to all changes: