> Le Sat, 29 Jun 2013 18:36:26 -0000,
> Christian Dywan <email address hidden> a écrit :
> 
> > I do notice something when creating a new folder:
> > GLib-CRITICAL **: g_str_has_prefix: assertion `str != NULL' failed
> >
> > I'm uncertain if this is due to this change or not. I'd appreciate if
> > somebody else can double-check.
> 
> Hi kalikiana,
> 
> I've checked lp:midori (revno: 6238), it does something very similar:
> 
> (midori4:8087): GLib-CRITICAL **: g_str_has_prefix: assertion `str !=
> NULL' failed

The problem actually comes from the midori_browser_update_history that's done in midori_browser_edit_bookmark_dialog_new.

It calls the function zeitgeist_manifestation_for_uri with the created folder's uri, which is a NULL string.

I wonder if midori_browser_update_history must be done in case of folder creation.

I wonder if it must be done in any case.

Here is the backtrace.

-------------------------------------------------------------------------------
env G_DEBUG=fatal-criticals _build/default/midori/midori -g

** (midori:8329): WARNING **: Couldn't connect to accessibility bus: Failed to connect to socket /tmp/dbus-06tODYGRbI: Connexion refusée
Launching command: '/usr/bin/gdb' --batch -ex 'set print thread-events off' -ex run -ex 'set logging on /run/user/1000/midori/gdb.bt' -ex 'bt' --return-child-result --args _build/default/midori/midori 
[Thread debugging using libthread_db enabled]
Using host libthread_db library "/lib/libthread_db.so.1".
warning: cannot close "/usr/lib/gio/modules/libgvfsdbus.so": Opération invalide
warning: cannot close "/lib/libgvfscommon.so.0": Opération invalide
warning: cannot close "/lib/libbluray.so.1": Opération invalide

** (midori:8332): WARNING **: Couldn't connect to accessibility bus: Failed to connect to socket /tmp/dbus-06tODYGRbI: Connexion refusée
warning: cannot close "/usr/lib/gio/modules/libgiognomeproxy.so": Opération invalide
warning: cannot close "/usr/lib/gio/modules/libgiolibproxy.so": Opération invalide
warning: cannot close "/lib/libproxy.so.1": Opération invalide
warning: cannot close "/lib/libmodman.so.1": Opération invalide
warning: cannot close "/usr/lib/gio/modules/libgsettingsgconfbackend.so": Opération invalide
warning: cannot close "/lib/libgconf-2.so.4": Opération invalide
Detaching after fork from child process 8339.
warning: cannot close "/usr/lib/gio/modules/libgiognutls.so": Opération invalide
warning: cannot close "/lib/libgnutls.so.26": Opération invalide
warning: cannot close "/lib/libtasn1.so.3": Opération invalide
warning: cannot close "/lib/libfam.so.0": Opération invalide
Detaching after fork from child process 8345.
java version "1.7.0_03"
OpenJDK Runtime Environment (fedora-2.3.9.8.fc18-i386)
OpenJDK Client VM (build 23.7-b01, mixed mode, sharing)

(midori4:8332): Gtk-WARNING **: Error loading theme icon 'text-x-javascript' for stock: L'icône « text-x-javascript » n'est pas présente dans le thème

(midori4:8332): Gtk-WARNING **: Can't set a parent on a toplevel widget


(midori4:8332): GLib-CRITICAL **: g_str_has_prefix: assertion `str != NULL' failed

Program received signal SIGTRAP, Trace/breakpoint trap.
g_logv (log_domain=log_domain@entry=0x41ea5aae "GLib", log_level=log_level@entry=G_LOG_LEVEL_CRITICAL, format=format@entry=0x41eadb36 "%s: assertion `%s' failed", args=args@entry=0xbfffe0fc "\350\026\353Azz\352AB\025\016\b") at gmessages.c:974
974		  g_private_set (&g_log_depth, GUINT_TO_POINTER (depth));
#0  g_logv (log_domain=log_domain@entry=0x41ea5aae "GLib", log_level=log_level@entry=G_LOG_LEVEL_CRITICAL, format=format@entry=0x41eadb36 "%s: assertion `%s' failed", args=args@entry=0xbfffe0fc "\350\026\353Azz\352AB\025\016\b") at gmessages.c:974
#1  0x41e3df94 in g_log (log_domain=log_domain@entry=0x41ea5aae "GLib", log_level=log_level@entry=G_LOG_LEVEL_CRITICAL, format=format@entry=0x41eadb36 "%s: assertion `%s' failed") at gmessages.c:1003
#2  0x41e3dfde in g_return_if_fail_warning (log_domain=log_domain@entry=0x41ea5aae "GLib", pretty_function=pretty_function@entry=0x41eb16e8 <__PRETTY_FUNCTION__.11249> "g_str_has_prefix", expression=0x41ea7a7a "str != NULL") at gmessages.c:1012
#3  0x41e56baa in g_str_has_prefix (str=0x0, prefix=0x92db170 "file://") at gstrfuncs.c:2780
#4  0x4213d397 in zeitgeist_manifestation_for_uri () from /lib/libzeitgeist-1.0.so.1
#5  0x08076d5c in midori_browser_update_history (item=0x91f3718 [KatzeArray], type=0x80e1542 "bookmark", event=0x80d3ffd "create") at ../midori/midori-browser.c:487
#6  0x0807f45a in midori_browser_edit_bookmark_dialog_new (browser=browser@entry=0x8e1f020 [MidoriBrowser], bookmark=0x91f3718 [KatzeArray], bookmark@entry=0x0, new_bookmark=new_bookmark@entry=1, is_folder=is_folder@entry=1, proxy=0x8f28990 [GtkToolButton]) at ../midori/midori-browser.c:1061
#7  0x080afae8 in midori_bookmarks_add_clicked_cb (toolitem=0x8f28990 [GtkToolButton]) at ../panels/midori-bookmarks.c:398
#8  0x41f38e2f in g_cclosure_marshal_VOID__VOIDv (closure=closure@entry=0x8f88bf0, return_value=return_value@entry=0x0, instance=instance@entry=0x8f28990, args=args@entry=0xbfffe5a8 "\020\330\033\t", marshal_data=marshal_data@entry=0x0, n_params=n_params@entry=0, param_types=param_types@entry=0x0) at gmarshal.c:115
#9  0x41f372b2 in _g_closure_invoke_va (closure=closure@entry=0x8f88bf0, return_value=return_value@entry=0x0, instance=instance@entry=0x8f28990, args=args@entry=0xbfffe5a8 "\020\330\033\t", n_params=n_params@entry=0, param_types=0x0) at gclosure.c:840
#10 0x41f50a06 in g_signal_emit_valist (instance=instance@entry=0x8f28990, signal_id=signal_id@entry=284, detail=detail@entry=0, var_args=var_args@entry=0xbfffe5a8 "\020\330\033\t") at gsignal.c:3211
#11 0x41f51895 in g_signal_emit_by_name (instance=instance@entry=0x8f28990, detailed_signal=detailed_signal@entry=0x415243aa "clicked") at gsignal.c:3393
#12 0x4143c451 in button_clicked (widget=0x8f29730 [GtkButton], button=0x8f28990 [GtkToolButton]) at gtktoolbutton.c:879
#13 0x41f38e2f in g_cclosure_marshal_VOID__VOIDv (closure=closure@entry=0x8ff61d0, return_value=return_value@entry=0x0, instance=instance@entry=0x8f29730, args=args@entry=0xbfffe85c "\357\305\327O", marshal_data=marshal_data@entry=0x0, n_params=n_params@entry=0, param_types=param_types@entry=0x0) at gmarshal.c:115
#14 0x41f372b2 in _g_closure_invoke_va (closure=closure@entry=0x8ff61d0, return_value=return_value@entry=0x0, instance=instance@entry=0x8f29730, args=args@entry=0xbfffe85c "\357\305\327O", n_params=n_params@entry=0, param_types=0x0) at gclosure.c:840
#15 0x41f50a06 in g_signal_emit_valist (instance=instance@entry=0x8f29730, signal_id=signal_id@entry=212, detail=detail@entry=0, var_args=var_args@entry=0xbfffe85c "\357\305\327O") at gsignal.c:3211
#16 0x41f513e4 in g_signal_emit (instance=instance@entry=0x8f29730, signal_id=212, detail=detail@entry=0) at gsignal.c:3356
#17 0x4125968a in gtk_button_clicked (button=0x8f29730 [GtkButton]) at gtkbutton.c:1308
#18 0x4125a4f8 in gtk_real_button_released (button=0x8f29730 [GtkButton]) at gtkbutton.c:1967
#19 0x41f38e0b in g_cclosure_marshal_VOID__VOIDv (closure=0x81b1918, return_value=0x0, instance=0x8f29730, args=0xbfffeb8c ",", marshal_data=0x4125a3e0 <gtk_real_button_released>, n_params=0, param_types=0x0) at gmarshal.c:115
#20 0x41f358e8 in g_type_class_meta_marshalv (closure=closure@entry=0x81b1918, return_value=return_value@entry=0x0, instance=instance@entry=0x8f29730, args=args@entry=0xbfffeb8c ",", marshal_data=marshal_data@entry=0x1fc, n_params=n_params@entry=0, param_types=param_types@entry=0x0) at gclosure.c:997
#21 0x41f372b2 in _g_closure_invoke_va (closure=closure@entry=0x81b1918, return_value=return_value@entry=0x0, instance=instance@entry=0x8f29730, args=args@entry=0xbfffeb8c ",", n_params=n_params@entry=0, param_types=0x0) at gclosure.c:840
#22 0x41f50a06 in g_signal_emit_valist (instance=instance@entry=0x8f29730, signal_id=signal_id@entry=211, detail=detail@entry=0, var_args=var_args@entry=0xbfffeb8c ",") at gsignal.c:3211
#23 0x41f513e4 in g_signal_emit (instance=instance@entry=0x8f29730, signal_id=211, detail=detail@entry=0) at gsignal.c:3356
#24 0x41258e86 in gtk_button_button_release (event=0x9060650, widget=0x8f29730 [GtkButton]) at gtkbutton.c:1802
#25 gtk_button_button_release (widget=0x8f29730 [GtkButton], event=event@entry=0x9060650) at gtkbutton.c:1794
#26 0x41344f71 in _gtk_marshal_BOOLEAN__BOXEDv (closure=0x8118018, return_value=0xbfffed24, instance=0x8f29730, args=0xbfffee8c "P\006\006\t\254\356\377\277\230-\021\b\004", marshal_data=0x41258e40 <gtk_button_button_release>, n_params=1, param_types=0x8118030) at gtkmarshalers.c:130
#27 0x41f358e8 in g_type_class_meta_marshalv (closure=closure@entry=0x8118018, return_value=return_value@entry=0xbfffed24, instance=instance@entry=0x8f29730, args=args@entry=0xbfffee8c "P\006\006\t\254\356\377\277\230-\021\b\004", marshal_data=marshal_data@entry=0xc4, n_params=n_params@entry=1, param_types=param_types@entry=0x8118030) at gclosure.c:997
#28 0x41f372b2 in _g_closure_invoke_va (closure=closure@entry=0x8118018, return_value=return_value@entry=0xbfffed24, instance=instance@entry=0x8f29730, args=args@entry=0xbfffee8c "P\006\006\t\254\356\377\277\230-\021\b\004", n_params=n_params@entry=1, param_types=0x8118030) at gclosure.c:840
#29 0x41f50a06 in g_signal_emit_valist (instance=instance@entry=0x8f29730, signal_id=signal_id@entry=29, detail=detail@entry=0, var_args=var_args@entry=0xbfffee8c "P\006\006\t\254\356\377\277\230-\021\b\004") at gsignal.c:3211
#30 0x41f513e4 in g_signal_emit (instance=instance@entry=0x8f29730, signal_id=29, detail=detail@entry=0) at gsignal.c:3356
#31 0x41495853 in gtk_widget_event_internal (widget=widget@entry=0x8f29730 [GtkButton], event=event@entry=0x9060650) at gtkwidget.c:6303
#32 0x41495c4f in gtk_widget_event (widget=widget@entry=0x8f29730 [GtkButton], event=event@entry=0x9060650) at gtkwidget.c:5960
#33 0x41342874 in propagate_event_up (topmost=<optimized out>, event=<optimized out>, widget=0x8f29730 [GtkButton]) at gtkmain.c:2397
#34 propagate_event (widget=<optimized out>, event=0x9060650, captured=0, topmost=0x0) at gtkmain.c:2505
#35 0x41344b50 in gtk_main_do_event (event=0x9060650) at gtkmain.c:1720
#36 0x417079ed in _gdk_event_emit (event=event@entry=0x9060650) at gdkevents.c:69
#37 0x41732239 in gdk_event_source_dispatch (source=source@entry=0x814b188, callback=0x0, user_data=0x0) at gdkeventsource.c:358
#38 0x41e3615b in g_main_dispatch (context=0x814b2a0, context@entry=0x815eb08) at gmain.c:2715
#39 g_main_context_dispatch (context=context@entry=0x814b2a0) at gmain.c:3219
#40 0x41e36500 in g_main_context_iterate (context=0x814b2a0, block=block@entry=1, dispatch=dispatch@entry=1, self=<optimized out>) at gmain.c:3290
#41 0x41e36963 in g_main_loop_run (loop=loop@entry=0x8153190) at gmain.c:3484
#42 0x41343cb5 in gtk_main () at gtkmain.c:1160
#43 0x08068b41 in main (argc=1, argv=0xbffff3b4) at ../midori/main.c:392