Merge lp:~aaronp/software-center/top-rated-gtk3-fixes into lp:software-center
Proposed by
Aaron Peachey
Status: | Merged |
---|---|
Merged at revision: | 2159 |
Proposed branch: | lp:~aaronp/software-center/top-rated-gtk3-fixes |
Merge into: | lp:software-center |
Diff against target: |
171 lines (+45/-56) 2 files modified
debian/changelog (+11/-1) softwarecenter/ui/gtk3/views/catview_gtk.py (+34/-55) |
To merge this branch: | bzr merge lp:~aaronp/software-center/top-rated-gtk3-fixes |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Michael Vogt | Approve | ||
Review via email: mp+72332@code.launchpad.net |
Description of the change
1. Fixes bug LP: #830272 for gtk3 - remove 'More' from top rated screens in subcategories and increase number of tiles to 12.
2. Simplify code in catview_gtk.py for gtk3 by providing a single method to add tiles to FlowableGrids rather than repeating the same code in all append_xxxxxx methods.
To post a comment you must log in.
Thanks, I love the _add_tiles_ to_flowgrid( ) fix!
I renamed qty to amount, I'm not a native speaker, but it feels a tiny bit more readable this way (and used min() while I was at it).
In the code: header_ label(_ ('Top Rated %s' % self.header)) label(_ ('Top Rated %s') % self.header)
+ frame.set_
this part will cause issues with i18n. it needs to be
set_header_
(not the slightly different parenthesis).
With the later, it will translate into e.g. "Superbewertung %s" and then the header is added.
When the parentheses are different it will first add the header and then try to translate. But that will fail as in gettext it expectes the "%s" in the string and will not find a match if that is not there (the string it will search for will be something like "Top Rated Internet" but the gettext catalogue only has "Top Rated %s").
I fixed that tiny issue during the merge.