Merge lp:~aaronp/software-center/enhance-usefulness into lp:software-center
Status: | Merged |
---|---|
Merged at revision: | 1760 |
Proposed branch: | lp:~aaronp/software-center/enhance-usefulness |
Merge into: | lp:software-center |
Diff against target: |
208 lines (+125/-8) 6 files modified
softwarecenter/app.py (+3/-1) softwarecenter/db/reviews.py (+58/-2) softwarecenter/paths.py (+1/-0) softwarecenter/utils.py (+10/-5) utils/get_useful_votes_helper.py (+45/-0) utils/submit_review.py (+8/-0) |
To merge this branch: | bzr merge lp:~aaronp/software-center/enhance-usefulness |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
software-store-developers | Pending | ||
Review via email: mp+59610@code.launchpad.net |
Commit message
enhance usefulness functionality to add support for getting user's votes from the server at startup and anytime we get the username of the user
Description of the change
- fix bug that causes crash when submitting usefulness because unused usefulness UI doesn't contain all elements that need to be updated since adding the error details expander (r1755)
- add support for getting user's votes from server by first loading them from local cache and then spawning a retrieval process in the background to populate them from the server once a response is received. Load from cache whenever UsefulnessCache object is created except upon startup (app.py) when we try to get them from the server (r1756-1758)
- don't update username into local config if the one we have is the same as the one we want to update. (r1759)
- if we DO update a new username into local config, try to update the UsefulnessCache from the server using the new username (as it's likely we didn't get it from the server at startup) (r1759)