Ubiquity Slideshow

Merge lp:~aaronhoneycutt/ubiquity-slideshow-ubuntu/zesty-2 into lp:ubiquity-slideshow-ubuntu

  1. zesty-2
  2. Merge into html
Proposed by Aaron Honeycutt on 2017-04-08
Status: Merged
Approved by: Mathieu Trudel-Lapierre on 2017-04-10
Approved revision: 776
Merged at revision: 775
Proposed branch: lp:~aaronhoneycutt/ubiquity-slideshow-ubuntu/zesty-2
Merge into: lp:ubiquity-slideshow-ubuntu
Diff against target: 40 lines (+4/-4)
3 files modified
slideshows/kubuntu/slides/games.html (+1/-1)
slideshows/kubuntu/slides/get-involved.html (+1/-1)
slideshows/kubuntu/slides/installing-software.html (+2/-2)
To merge this branch: bzr merge lp:~aaronhoneycutt/ubiquity-slideshow-ubuntu/zesty-2
Reviewer Review Type Date Requested Status
Mathieu Trudel-Lapierre 2017-04-08 Approve on 2017-04-10
Review via email: mp+322252@code.launchpad.net
To post a comment you must log in.
Mathieu Trudel-Lapierre (cyphermox) wrote :

This link change without updating href looks highly suspect to me:

- href="https://userbase.kde.org/Kubuntu/Contribute">userbase.kde.org/Kubuntu/Contribute</a>
+ href="https://userbase.kde.org/Kubuntu/Contribute">http://docs.kubuntu.org/docs/contribute.html</a>

I think you might want to have both href and the a tag's content be the same, so that people copy-pasting will still get the right URL.

review: Needs Fixing
lp:~aaronhoneycutt/ubiquity-slideshow-ubuntu/zesty-2 updated on 2017-04-09
776. By Aaron Honeycutt <email address hidden> on 2017-04-09

update href as per review

Aaron Honeycutt (aaronhoneycutt) wrote :

Pushing the fix now, thanks.

Mathieu Trudel-Lapierre (cyphermox) :
review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'slideshows/kubuntu/slides/games.html'
2--- slideshows/kubuntu/slides/games.html 2015-09-08 17:00:05 +0000
3+++ slideshows/kubuntu/slides/games.html 2017-04-09 22:21:08 +0000
4@@ -7,7 +7,7 @@
5 allows you to not be all about work, but also allows you to
6 play.</li>
7 <li>You can easily install Steam</li>
8- <li>The <em>KDE Software Compilation</em> has quite a few games
9+ <li>The <em>KDE Applications</em> has quite a few games
10 ranging from card games to logic games and board games.</li>
11 <li>First Person Shooters, Role Playing Games, and more are also
12 available in the repositories.</li>
13
14=== modified file 'slideshows/kubuntu/slides/get-involved.html'
15--- slideshows/kubuntu/slides/get-involved.html 2015-03-31 23:17:41 +0000
16+++ slideshows/kubuntu/slides/get-involved.html 2017-04-09 22:21:08 +0000
17@@ -12,7 +12,7 @@
18 mold the future of Kubuntu is easy, and you are more than welcome
19 to help out.</li>
20 <li>Look over <a
21- href="https://userbase.kde.org/Kubuntu/Contribute">userbase.kde.org/Kubuntu/Contribute</a>
22+ href="http://docs.kubuntu.org/docs/contribute.html">http://docs.kubuntu.org/docs/contribute.html</a>
23 and see where you might be able to help out. Remember, it is easy
24 to get involved and the work you do will be seen by millions of
25 people around the world.</li>
26
27=== modified file 'slideshows/kubuntu/slides/installing-software.html'
28--- slideshows/kubuntu/slides/installing-software.html 2015-03-31 23:17:41 +0000
29+++ slideshows/kubuntu/slides/installing-software.html 2017-04-09 22:21:08 +0000
30@@ -3,8 +3,8 @@
31 <div class="main">
32 <div class="content">
33 <ul>
34- <li>Take a look at the <em>Muon Discover</em> application in the
35- menu. Muon Discover will allow you to
36+ <li>Take a look at the <em>Discover</em> application in the
37+ menu. Discover will allow you to
38 install (and remove) software from our online repositories, which
39 we carefully organize to be safe and up to date.</li>
40 <li>There is great software for everything from creating music and

Subscribers

People subscribed via source and target branches