Merge ~aaronhoneycutt/kubuntu-packaging/+git/kalzium:kubuntu_unstable into ~kubuntu-packagers/kubuntu-packaging/+git/kalzium:kubuntu_unstable
Proposed by
Aaron Honeycutt
on 2016-11-27
| Status: | Merged |
|---|---|
| Merged at revision: | 03a3b6296735c102ed745efa801a4fcabd9abe51 |
| Proposed branch: | ~aaronhoneycutt/kubuntu-packaging/+git/kalzium:kubuntu_unstable |
| Merge into: | ~kubuntu-packagers/kubuntu-packaging/+git/kalzium:kubuntu_unstable |
| Diff against target: |
37 lines (+14/-0) 2 files modified
debian/changelog (+1/-0) debian/control (+13/-0) |
| Related bugs: |
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Simon Quigley | 2016-11-27 | Approve on 2016-11-27 | |
|
Review via email:
|
|||
Description of the Change
Added:
- libkf5i18n-dev
- libkf5kdelibs4s
- libkf5khtml-dev
- libkf5newstuff-dev
- libkf5parts-dev
- libkf5plotting-dev
- libkf5solid-dev
- libkf5unitconve
- libkf5widgetsad
- libkf5archive-dev
- libkf5config-dev
- libkf5coreaddon
- kdoctools-dev
To post a comment you must log in.
| Aaron Honeycutt (aaronhoneycutt) wrote : | # |
I'm not sure why it needs all of them now, the logs are just saying that it needs a ton of cmake files and those packages provide them.
| Simon Quigley (tsimonq2) wrote : | # |
Alright, then say something like "Upstream has new build deps that we need"
Preview Diff
[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
At this point with the changelog, I would use a more general entry and just one entry total. It makes the changelog less cluttered. If you can find out why we need these all of a sudden, put that there as well. :)
Otherwise, lgtm.