Merge lp:~aaron-whitehouse/duplicity/tox_pylint_fixes into lp:~duplicity-team/duplicity/0.8-series
Status: | Merged |
---|---|
Merged at revision: | 1224 |
Proposed branch: | lp:~aaron-whitehouse/duplicity/tox_pylint_fixes |
Merge into: | lp:~duplicity-team/duplicity/0.8-series |
Diff against target: |
37 lines (+9/-3) 2 files modified
duplicity/compilec.py (+3/-1) tox.ini (+6/-2) |
To merge this branch: | bzr merge lp:~aaron-whitehouse/duplicity/tox_pylint_fixes |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
duplicity-team | Pending | ||
Review via email: mp+323996@code.launchpad.net |
Commit message
Changes needed to run-tests without pylint E0401(import-error) errors
Description of the change
If I run run-tests on the current trunk, I get the following errors:
Pylint test (requires pylint to be installed to pass) ... FAIL
=======
FAIL: test_pylint (testing.
Pylint test (requires pylint to be installed to pass)
-------
Traceback (most recent call last):
File "/home/
[0, 32])
File "/home/
self.
AssertionError: ************* Module duplicity.compilec
/home/aaron/
************* Module duplicity.
/home/aaron/
************* Module duplicity.
/home/aaron/
/home/aaron/
************* Module duplicity.
/home/aaron/
************* Module duplicity.
/home/aaron/
With the changes proposed, run-test completes for me without errors.
Presumably these errors do not happen (except perhaps the distutils one?) if all requirements are installed, but if adding them to tox.ini can sort them out (and therefore lower the bar for people to get testing working properly), why not do so?
I merged this in because I'm tired of chasing the issue.
However, there is no difference in compilec.py between 0.7x and 0.8x, yet 0.8x fails and 0.7x passes. The bug you quoted does not seem to occur to 0.7x, only to 0.8x, and I do not understand that at all. Plus, the problem has only cropped up recently.