Merge lp:~aacid/unity8/warn_using_only_cache into lp:unity8

[Albert Astals Cid]

 Warn we're using only the cache when not connected to the interwebs

 * Are there any related MPs required for this MP to build/function as expected?
No

 * Did you perform an exploratory manual test run of your code change and any related functionality?
Yes

 * Did you make sure that your branch does not contain spurious tags?
Yes

 * If you changed the packaging (debian), did you subscribe the ubuntu-unity team to this MP?
N/A

 * If you changed the UI, has there been a design review?
N/A

[PS Jenkins bot (ps-jenkins)]

FAILED: Continuous integration, rev:2020
http://jenkins.qa.ubuntu.com/job/unity8-ci/6567/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-vivid-touch/4858
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-wily-touch/950/console
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity-phablet-qmluitests-vivid/1279
    FAILURE: http://jenkins.qa.ubuntu.com/job/unity-phablet-qmluitests-wily/595/console
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity8-vivid-amd64-ci/1174
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity8-vivid-i386-ci/1175
    FAILURE: http://jenkins.qa.ubuntu.com/job/unity8-wily-amd64-ci/806/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/unity8-wily-i386-ci/807/console
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-runner-vivid-mako/3911
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-vivid-armhf/4855
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-vivid-armhf/4855/artifact/work/output/*zip*/output.zip
    SUCCESS: http://s-jenkins.ubuntu-ci:8080/job/touch-flash-device/24616
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-wily-armhf/950/console

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/unity8-ci/6567/rebuild

review: Needs Fixing (continuous-integration)

[Michael Terry (mterry)]

Did we have a hard time debugging a cache usage recently or something? Regardless, looks fine.

 * Did you perform an exploratory manual test run of the code change and any related functionality?
 Naw, this is just a debug print.

 * Did CI run pass? If not, please explain why.
 No, but for unrelated reasons.

 * Did you make sure that the branch does not contain spurious tags?
 Yes

review: Approve

[Albert Astals Cid (aacid)]

> Did we have a hard time debugging a cache usage recently or something?
There's an on an off bug of people not getting images in dash, it's probably not because of this thinks we're not connected and we're actually connected, want to make sure it's easier to find out if that's the case.

=== modified file 'src/CachingNetworkManagerFactory.cpp'
--- src/CachingNetworkManagerFactory.cpp	2015-09-14 09:11:08 +0000
+++ src/CachingNetworkManagerFactory.cpp	2015-10-27 14:19:56 +0000
@@ -30,6 +30,7 @@
 QNetworkReply* CachingNetworkAccessManager::createRequest(Operation op, const QNetworkRequest &request, QIODevice *outgoingData)
 {
     if (m_networkingStatus->status() != ubuntu::connectivity::NetworkingStatus::Status::Online) {
+        qDebug() << "Not connected to the internet. Request for" << request.url().toString() << "will be served only from the cache.";
         QNetworkRequest req(request);
         req.setAttribute(QNetworkRequest::CacheLoadControlAttribute, QNetworkRequest::AlwaysCache);
         return QNetworkAccessManager::createRequest(op, req, outgoingData);