Merge lp:~aacid/unity8/waitForTransitionsOnInit into lp:unity8

[Albert Astals Cid]

tst_PreviewZoomableImage: Wait for LazyImage transitions on init()

This fails locally with:
$ while parallel -i -j10 make -C builddir xvfbtestPreviewZoomableImage FUNCTION=PreviewZoomableImageTest::test_zoomableImageOpenClose -- {1..10}; do :; done

 * Are there any related MPs required for this MP to build/function as expected?
No

 * Did you perform an exploratory manual test run of your code change and any related functionality?
Yes

 * If you changed the packaging (debian), did you subscribe the ubuntu-unity team to this MP?
N/A

 * If you changed the UI, has there been a design review?
N/A

[Albert Astals Cid (aacid)]

This is another way to fix the problem as opposed to https://code.launchpad.net/~saviq/unity8/delay-mouseclick-previewzoomable/+merge/305829

[Unity8 CI Bot (unity8-ci-bot)]

FAILED: Continuous integration, rev:2652
https://unity8-jenkins.ubuntu.com/job/lp-unity8-ci/2266/
Executed test runs:
    FAILURE: https://unity8-jenkins.ubuntu.com/job/build/2987/console
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-0-fetch/3015
    FAILURE: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=amd64,release=vivid+overlay/2873/console
    FAILURE: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=amd64,release=xenial+overlay/2873/console
    FAILURE: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=amd64,release=yakkety/2873/console
    FAILURE: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=armhf,release=vivid+overlay/2873/console
    FAILURE: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=armhf,release=xenial+overlay/2873/console
    FAILURE: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=armhf,release=yakkety/2873/console
    FAILURE: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=i386,release=vivid+overlay/2873/console
    FAILURE: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=i386,release=xenial+overlay/2873/console
    FAILURE: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=i386,release=yakkety/2873/console

Click here to trigger a rebuild:
https://unity8-jenkins.ubuntu.com/job/lp-unity8-ci/2266/rebuild

review: Needs Fixing (continuous-integration)

[lp:~aacid/unity8/waitForTransitionsOnInit]

2653. By Albert Astals Cid on 2016-09-29

whitespaaaaaaaaaaaace

[Unity8 CI Bot (unity8-ci-bot)]

PASSED: Continuous integration, rev:2653
https://unity8-jenkins.ubuntu.com/job/lp-unity8-ci/2278/
Executed test runs:
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build/2999
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/test-0-autopkgtest/label=amd64,release=vivid+overlay,testname=qmluitests.sh/1659
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/test-0-autopkgtest/label=amd64,release=xenial+overlay,testname=qmluitests.sh/1659
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/test-0-autopkgtest/label=amd64,release=yakkety,testname=qmluitests.sh/1659
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-0-fetch/3027
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=amd64,release=vivid+overlay/2884
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=amd64,release=vivid+overlay/2884/artifact/output/*zip*/output.zip
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=amd64,release=xenial+overlay/2884
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=amd64,release=xenial+overlay/2884/artifact/output/*zip*/output.zip
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=amd64,release=yakkety/2884
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=amd64,release=yakkety/2884/artifact/output/*zip*/output.zip
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=armhf,release=vivid+overlay/2884
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=armhf,release=vivid+overlay/2884/artifact/output/*zip*/output.zip
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=armhf,release=xenial+overlay/2884
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=armhf,release=xenial+overlay/2884/artifact/output/*zip*/output.zip
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=armhf,release=yakkety/2884
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=armhf,release=yakkety/2884/artifact/output/*zip*/output.zip
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=i386,release=vivid+overlay/2884
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=i386,release=vivid+overlay/2884/artifact/output/*zip*/output.zip
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=i386,release=xenial+overlay/2884
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=i386,release=xenial+overlay/2884/artifact/output/*zip*/output.zip
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=i386,release=yakkety/2884
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=i386,release=yakkety/2884/artifact/output/*zip*/output.zip

Click here to trigger a rebuild:
https://unity8-jenkins.ubuntu.com/job/lp-unity8-ci/2278/rebuild

review: Approve (continuous-integration)

[Lukáš Tinkl (lukas-kde)]

Makes sense, CI agrees too

review: Approve

=== modified file 'tests/qmltests/Dash/Previews/tst_PreviewZoomableImage.qml'
--- tests/qmltests/Dash/Previews/tst_PreviewZoomableImage.qml	2016-08-30 14:06:47 +0000
+++ tests/qmltests/Dash/Previews/tst_PreviewZoomableImage.qml	2016-09-29 08:52:17 +0000
@@ -74,6 +74,11 @@
             waitForRendering(zoomableImage);
             overlay = findChild(zoomableImage.rootItem, "overlay");
             waitForRendering(overlay);
+
+            // Make sure all the lazyImage transitions have finished
+            for (var i in lazyImage.transitions) {
+                tryCompare(lazyImage.transitions[i], "running", false);
+            }
         }
 
         function cleanup() {