Merge lp:~aacid/unity8/stabilize-launcher-test-more into lp:unity8

[Albert Astals Cid]

Make Launcher::test_quickListMenuOnRMB stable

We need the x to be exactly 0 and compare() does say true for values very close to 0

 * Are there any related MPs required for this MP to build/function as expected?
No

 * Did you perform an exploratory manual test run of your code change and any related functionality?
Yes

 * Did you make sure that your branch does not contain spurious tags?
Yes

 * If you changed the packaging (debian), did you subscribe the ubuntu-unity team to this MP?
N/A

 * If you changed the UI, has there been a design review?
N/A

[Michael Zanetti (mzanetti)]

 * Did you perform an exploratory manual test run of the code change and any related functionality?

yes

 * Did CI run pass? If not, please explain why.

waiting, shouldn't affect anything bad tho. I've ran the tests here.

 * Did you make sure that the branch does not contain spurious tags?

yes

review: Approve

[PS Jenkins bot (ps-jenkins)]

FAILED: Continuous integration, rev:1980
http://jenkins.qa.ubuntu.com/job/unity8-ci/6370/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-vivid-touch/4398
    UNSTABLE: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-wily-touch/747
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity-phablet-qmluitests-vivid/1082
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity-phablet-qmluitests-wily/400
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity8-vivid-amd64-ci/977
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity8-vivid-i386-ci/978
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity8-wily-amd64-ci/609
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity8-wily-i386-ci/610
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-runner-vivid-mako/3580
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-vivid-armhf/4395
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-vivid-armhf/4395/artifact/work/output/*zip*/output.zip
    SUCCESS: http://s-jenkins.ubuntu-ci:8080/job/touch-flash-device/23743
    UNSTABLE: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-runner-wily-mako/449
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-wily-armhf/747
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-wily-armhf/747/artifact/work/output/*zip*/output.zip
    SUCCESS: http://s-jenkins.ubuntu-ci:8080/job/touch-flash-device/23742

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/unity8-ci/6370/rebuild

review: Needs Fixing (continuous-integration)

=== modified file 'tests/qmltests/Launcher/tst_Launcher.qml'
--- tests/qmltests/Launcher/tst_Launcher.qml	2015-09-29 09:01:22 +0000
+++ tests/qmltests/Launcher/tst_Launcher.qml	2015-09-29 09:01:23 +0000
@@ -200,7 +200,10 @@
             verify(!!panel);
 
             // wait until it gets fully extended
-            tryCompare(panel, "x", 0);
+            // a tryCompare doesn't work since
+            //    compare(-0.000005917593600024418, 0);
+            // is true and in this case we want exactly 0 or will have pain later on
+            tryCompareFunction( function(){ return panel.x === 0; }, true );
             tryCompare(launcher, "state", "visible");
         }