Merge lp:~aacid/unity8/remove_unused_end into lp:unity8

Proposed by Albert Astals Cid
Status: Merged
Approved by: Daniel d'Andrada
Approved revision: 1369
Merged at revision: 1403
Proposed branch: lp:~aacid/unity8/remove_unused_end
Merge into: lp:unity8
Diff against target: 11 lines (+0/-2)
1 file modified
libs/UbuntuGestures/Pool.h (+0/-2)
To merge this branch: bzr merge lp:~aacid/unity8/remove_unused_end
Reviewer Review Type Date Requested Status
PS Jenkins bot (community) continuous-integration Needs Fixing
Daniel d'Andrada (community) Approve
Review via email: mp+239294@code.launchpad.net

Commit message

Remove unused end() function

Description of the change

 * Are there any related MPs required for this MP to build/function as expected?
No

 * Did you perform an exploratory manual test run of your code change and any related functionality?
N/A

 * Did you make sure that your branch does not contain spurious tags?
Yes

 * If you changed the packaging (debian), did you subscribe the ubuntu-unity team to this MP?
N/A

 * If you changed the UI, has there been a design review?
N/A

To post a comment you must log in.
Revision history for this message
Daniel d'Andrada (dandrader) wrote :

* Did you perform an exploratory manual test run of the code change and any related functionality?
Not applicable

* Did CI run pass? If not, please explain why.
No results yet.

 * Did you make sure that the branch does not contain spurious tags?
Yes

review: Approve
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Needs Fixing (continuous-integration)
Revision history for this message
Daniel d'Andrada (dandrader) wrote :

* Did CI run pass? If not, please explain why.
No, due to an unrelated autopilot failure.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'libs/UbuntuGestures/Pool.h'
2--- libs/UbuntuGestures/Pool.h 2014-10-01 13:20:32 +0000
3+++ libs/UbuntuGestures/Pool.h 2014-10-22 20:06:32 +0000
4@@ -74,8 +74,6 @@
5 ItemType *item;
6 };
7
8- Iterator &end() const { return Iterator(); }
9-
10 ItemType &getEmptySlot() {
11 Q_ASSERT(m_lastUsedIndex < m_slots.size());
12

Subscribers

People subscribed via source and target branches