lp:~aacid/unity8/removeUnusedHasAttributes

Branch merges

Propose for merging

No branches dependent on this one.

Merged into lp:unity8 at revision 1238

Ying-Chun Liu (community): Approve on 2014-08-31

PS Jenkins bot (community): Needs Fixing (continuous-integration) on 2014-08-28

Diff: 28 lines (+5/-8)

1 file modified

qml/Dash/CardTool.qml (+5/-8)

api

Related source package recipes

No recipes using this branch. (?)

Create packaging recipe

Related snap packages

Related bugs

Related blueprints

1201. By Albert Astals Cid on 2014-08-28

Merge

1200. By Albert Astals Cid on 2014-08-25

Remove unused hasAttributes variable

1199. By Launchpad Translations on behalf of unity-team on 2014-08-24

Launchpad automatic translations update.

1198. By Launchpad Translations on behalf of unity-team on 2014-08-23

Launchpad automatic translations update.

1197. By PS Jenkins bot on 2014-08-22

Releasing 8.00+14.10.20140822-0ubuntu1

1196. By Mirco Müller on 2014-08-22

Made notification qml-test pass again by using Component.onCompleted instead of onOpacityChanged for the time being.
Approved by: Michał Sawicz, PS Jenkins bot

1195. By Albert Astals Cid on 2014-08-22

PreviewExpandable: "widgets" is a model, not an array
Approved by: Andrea Cimitan, Pawel Stolowski, Michał Sawicz

1194. By Gerry Boland on 2014-08-22

Cancel open PAM interactions on shutdown - fixes hang on logout on desktop Fixes: 1353041
Approved by: Michał Sawicz, Michael Terry, Christopher Townsend, PS Jenkins bot

1193. By Michael Zanetti on 2014-08-22

Implement new lockscreen designs
Approved by: Michael Terry

1192. By Michael Terry on 2014-08-22

Allow logging into a desktop or tablet session again, by properly dismissing old PAM conversations. (LP: #1350878)

In a desktop or tablet, we were accidentally starting two PAM conversations in sequence on startup. Which is a small bug; it shouldn't normally be a problem, since each new PAM conversation should kill the old one.

But the way we were killing the old one was subject to a thread race condition. See, a PAM conversation thread won't exit until all its prompts are answered. And what we do when we kill a PAM conversation is to answer all prompts with empty strings.

But it's possible that when we want to kill a PAM conversation that it hasn't actually gotten to the point of prompting us yet. And when those prompts do come through, we were treating them as prompts for the new PAM conversation.

So I've changed the PAM conversation logic to include a pam_handle and compare the handle with the current handle when being prompted. If it's an old handle, we just dismiss the prompt with an empty string response.

Oh, and I fixed the bug that caused two prompts on startup in the first place. (But we still need the above logic anyway, for when you switch users quickly.) Fixes: 1350878
Approved by: Michał Sawicz, Stephen M. Webb, PS Jenkins bot